Skip to content

Fix inheritance ordering - #286

Merged
james-toussaint merged 4 commits into
OpenZeppelin:hardhat3from
james-toussaint:fix/inheritance-ordering
Sep 23, 2026
Merged

james-toussaint merged 4 commits into
OpenZeppelin:hardhat3from
james-toussaint:fix/inheritance-ordering

Conversation

@james-toussaint

@james-toussaint james-toussaint commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Target: #283.

@james-toussaint
james-toussaint requested a review from a team as a code owner September 21, 2026 09:39
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 80b7dacb-cfce-48c1-8009-265eb26d20c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was updated in vanilla. It uses the "files" from package.json to filter which contract are in scope.

Would it work to "just" use that script (from vanilla here) ? Ideally we would not want to maintain 2 different versions

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it would be great to parametrize vanilla script and symlink it here.
Also this PR fixes the order issue: #287

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Replace the hardcoded skip list with the npm `files` patterns so the check
covers exactly what gets published, and merge the two AST passes into one.
@james-toussaint
james-toussaint merged commit 0d1308f into OpenZeppelin:hardhat3 Sep 23, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants