Repository navigation
Use npmFilesToBuild instead of import.sol for test dependencies #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amxx
wants to merge
5
commits into
hardhat3
Choose a base branch
from
hardhat3-npm-files-to-build
base: hardhat3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6d2565b
Replace import.sol with npmFilesToBuild
Amxx 18c6ae8
Update the upgradeable patch
Amxx 3c6127d
Bump OpenZeppelin Contracts to the latest commit of OpenZeppelin/open…
Amxx f8c10bf
Bump OpenZeppelin Contracts to the latest commit of OpenZeppelin/open…
Amxx 4446d03
Expose npmFilesToBuild with a glob
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule @openzeppelin-contracts
updated
5 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing the dependency tree creates duplicate
$artifact names that the upgradeable tests look up by bare name.The patch adds
lib/openzeppelin-community-contracts/contractsas a compilation root at line 36 and exposes it through the pattern at line 48. Its contracts duplicate the localcontracts/tree. For example,RoleAccountis declared atcontracts/account/RoleAccount.sol:31and in the dependency at the same relative path. Both files now produce a$RoleAccountartifact.The tests deploy these artifacts by bare name, such as
ethers.deployContract('$RoleAccount')attest/account/RoleAccount.test.js:9andethers.deployContract('$ERC7579Signature')attest/account/modules/ERC7579Validator.test.js:18. Hardhat rejects an ambiguous bare name, so these lookups fail in the upgradeable workflow.Each bare
$lookup must resolve to exactly one artifact. Choose one of the following: