v2.11.0 Release Changes

README.md

@@ -5,7 +5,7 @@
 # Network Optimizer for UniFi
 
 [![GitHub Release](https://img.shields.io/github/v/release/Ozark-Connect/NetworkOptimizer)](https://github.com/Ozark-Connect/NetworkOptimizer/releases)
-[![Docker Pulls](https://img.shields.io/badge/docker_pulls-767k-blue?logo=docker)](https://github.com/orgs/Ozark-Connect/packages?repo_name=NetworkOptimizer)
+[![Docker Pulls](https://img.shields.io/badge/docker_pulls-803k-blue?logo=docker)](https://github.com/orgs/Ozark-Connect/packages?repo_name=NetworkOptimizer)
 [![Windows Downloads](https://img.shields.io/github/downloads/Ozark-Connect/NetworkOptimizer/total?label=windows%20downloads)](https://github.com/Ozark-Connect/NetworkOptimizer/releases)
 [![GitHub last commit](https://img.shields.io/github/last-commit/Ozark-Connect/NetworkOptimizer)](https://github.com/Ozark-Connect/NetworkOptimizer/commits)
 [![GitHub Stars](https://img.shields.io/github/stars/Ozark-Connect/NetworkOptimizer)](https://github.com/Ozark-Connect/NetworkOptimizer/stargazers)
@@ -108,6 +108,7 @@ Track signal quality on your cable modem, fiber ONT, and cellular modems over ti
 - **Vodafone Station** - ARRIS TG3442DE
 - **Sagemcom** - F3896LG (Virgin Media Hub 5, Ziggo SmartWifi)
 - **FRITZ!Box Cable** - 6690 Cable (FRITZ!OS 8.40)
+- **UniFi Cable Internet** - through an On-Site Agent on the gateway (thanks to robry84, whose [uci-inform-exporter](https://gitlab.com/robry84/uci-inform-exporter) we checked our inform decoding against)
 
 ![Cable Modem Stats card with downstream SNR gauge, channel counts, power levels and FEC error counts](docs/images/cable-modem-stats.png)
 
@@ -117,9 +118,11 @@ Track signal quality on your cable modem, fiber ONT, and cellular modems over ti
 - **Quantum Fiber** - Q1000K SmartNID (CenturyLink)
 - **Nokia** - XS-010X-Q (Alcatel-Lucent, ALCL). GPON siblings (G-010S-P, G-010G-Q) may share the same GponForm API - untested, reports welcome
 - **Deutsche Telekom** - Glasfaser-Modem 2 (FTTH bridge mode)
-- **Realtek-based GPON sticks** (RTL960x) - ODI DFP-34X-2C2, V-SOL V2801F, T&W TWCGPON657
+- **Richerlink** - RL821GWV-D
+- **Realtek-based GPON sticks** (RTL960x) - ODI DFP-34X-2C2, ODI DFP-34X-2IY3, V-SOL V2801F, T&W TWCGPON657, Luleey LL-XS2510
 - **Zyxel GPON stick** - PMG3000-D20B (MaxLinear / T&W based)
 - **8311 community firmware XGS-PON sticks** - WAS-110 (MaxLinear PRX126), X-ONU-SFPP, WT-ONU-STICK, and other sticks running 8311
+- **Peter-Pon firmware GPON sticks** - FS.com GPON-SFP-ONT-MAC-I, Huawei MA5671A, and other Lantiq PEB98035 sticks
 
 SFP-based ONT monitoring (modules plugged into your gateway that expose DDM optical data) is part of the Network Monitoring feature below and also has a custom ONT stats augmentation API you can code to.
 
@@ -128,9 +131,10 @@ SFP-based ONT monitoring (modules plugged into your gateway that expose DDM opti
 **Cellular Modems** - RSRP, RSRQ, SNR, and Signal Quality charted over time with per-band, per-device series and filter badges.
 
 - **Ubiquiti** - U-LTE, U5G-Max, U5G-Backup, and the UDR-5G-Max's built-in modem (over Gateway SSH)
-- **Netgear Nighthawk** - modems and hotspots
-- **GL-iNet / Quectel** - modems and routers
+- **Netgear Nighthawk** - modems and hotspots (MR5200, M6)
+- **GL-iNet / Quectel** - modems and routers (GL-X3000, GL-XE3000, GL-X2000, GL-E750V2, GL-E5800 Mudi 7)
 - **Inseego** - FX4100 5G gateway
+- **MikroTik** - RouterOS 7 LTE/5G routers over SSH
 - **Zyxel** - NR7101, NR7102, NR7301, NR7302, NR7303, NR5103E, NR5103 v2, NR5307, FWA505, FWA510, FWA710, LTE3202, LTE5398, LTE7490
 
 Dual-connectivity mode tracks LTE and NR5G bands separately for NSA setups.
@@ -171,7 +175,7 @@ These are the highlights. For the complete list, organized the way the app is na
 
 ### Wi-Fi Optimizer & Signal Map
 
-Site health scoring, RF environment analysis, client stats, roaming tracking, band steering, and airtime fairness across twelve analysis tabs. Most channel pickers count nearby networks. Channel Recommendation models your RF physically: propagation from your floor plan, walls, and antenna patterns, each AP's real transmit power, and contention judged at the CCA threshold where radios actually defer. Add measured airtime, noise floor, triangulated neighbors, and months of how your own channels performed, and it solves for the least-interference plan across the whole site. Every move must clear its own improvement bar and never lands on a channel that measures worse, and mesh, DFS, and pins are respected. Apply Recommended Channels writes the plan to UniFi Network in waves, so a client always has a neighbor to roam to.
+Wi-Fi health scoring, RF environment analysis, client stats, roaming tracking, band steering, and airtime fairness across twelve analysis tabs. Most channel pickers count nearby networks. Channel Recommendation models your RF physically: propagation from your floor plan, walls, and antenna patterns, each AP's real transmit power, and contention judged at the CCA threshold where radios actually defer. Add measured airtime, noise floor, triangulated neighbors, and months of how your own channels performed, and it solves for the least-interference plan across the whole site. Every move must clear its own improvement bar and never lands on a channel that measures worse, and mesh, DFS, and pins are respected. Apply Recommended Channels writes the plan to UniFi Network in waves, so a client always has a neighbor to roam to.
 
 On the client side, you get a sortable, searchable table view with online/offline filtering, per-client signal and roaming history, and band-segmented Wi-Fi generation breakdowns showing exactly where your airtime is going. Environmental correlation heatmaps surface interference patterns by time of day and day of week, and every recommendation includes the specific UniFi Network UI navigation path to apply the change.
 

TODO.md

@@ -303,6 +303,10 @@ through our own SSH-deployed components, where we control the format and the rol
   MLO-enabled WLANs. The WiFi Optimizer health issue has not adopted it - `WiFiOptimizerService` still
   flags MLO from `hasWifi7Aps && hasMloEnabledWlan` (any AP + any WLAN), so an AP that broadcasts no
   MLO SSID is still counted. Reuse the path-analysis pattern.
+- **Propagation calibration from sibling sightings** - an AP's scan radio hears every sibling AP's BSSIDs
+  with a real signal level (`NeighborNetwork.IsSiteBssid`, shown on RF Environment's Site Access Points
+  card). That is measured AP-to-AP path loss. It could calibrate the propagation model, and stand in for
+  floor-plan placement on sites without one.
 - **MLO STR mesh backhaul (multi-band):** Channel recommendations pin a mesh child to its leader's channel only on the single band `AccessPointSnapshot.MeshUplinkBand` reports. AP-to-AP MLO STR backhaul can run over multiple bands at once (e.g. 5 + 6 GHz). When UniFi exposes per-link bands, make `MeshUplinkBand` a set and have `BuildMeshConstraints` emit one constraint per participating band. The reconciliation logic in `ChannelRecommendationService` keys off `MeshGroupLeader` and needs no change - only the constraint-building. See `TODO(MLO)` in `BuildMeshConstraints`. Dormant: no AP-to-AP MLO STR backhaul hardware exists yet (today's MLO STR is client/bridge only - UDB-Switch and AirWire, the MLO STR bridge - which are endpoints, not mesh-AP children, so they never hit this path).
 
 ### AP Catalog: Enforce 5 GHz EIRP Cap (US Regulatory)
@@ -404,6 +408,14 @@ all - it is collected and never shown. Either surface it or drop the field.
 - **Affected code:** `Alerts.razor: FormatStartTime()`, `UtcToLocalTimeOnly()`, `ParseTimeInput()`
 - **Options:** Store IANA timezone per schedule, use `TimeZoneInfo.ConvertTimeFromUtc`, or store local time + timezone
 
+### Default date and time format for alert text
+- Alert text is written once, for no viewer, so its times are 24-hour on every install
+- Settings has an install-wide **Default time zone**, which the notification clock already falls back to (`NotificationTimeZoneResolver`); the time format and date order have no install default, only each user's own choice (`ITimeZonePreferenceSource.GetOwnFormatAsync`)
+- Two places format alert times without a viewer:
+  - Rollout alert copy (`RolloutScopeCopy.AlertStartLabel`, `Moved`) uses `DisplayFormat.Fallback` (24-hour, month first)
+  - The Email, Slack, Teams, Discord, and ntfy channels stamp times with `TimestampFormatter`, which hard-codes `yyyy-MM-dd HH:mm:ss` and `HH:mm`
+- **Fix:** add a default time format and date order beside **Default time zone**, resolve it with the notification clock, and use it in both places
+
 ### Threat Alert Dedup Tuning (if users report noise)
 
 Current state (as of v1.5.x): Dedup is working - event-level dedup via InnerAlertId, pattern-level dedup via DedupKey with 6h merge window, rule-level cooldown at 1h. No spam reported yet, but here are levers to pull if it gets noisy:
@@ -1448,3 +1460,36 @@ The Threat Intelligence noise filters no longer apply to WAF events (`ThreatRepo
 they describe IPS flows, and a WAF event's port 443 is a placeholder, so "my phone, port 443" hid
 every WAF event from that phone. If the WAF page needs a hide-this-source control, give it filters of
 its own (source, host, rule) rather than reusing the IPS ones. False positives belong in exclusions.
+
+## Change Control: auto-revert for changes made in UniFi Network
+
+The auto-revert covers plans applied through Change Control: if a plan cuts the site or a device off
+from Network Optimizer, it rolls itself back (the On-Site Agent does it on an agent site). A change
+made directly in UniFi Network (the console UI, the mobile app, another integration) has no such
+safety net, though Change Control records it within a poll.
+
+Offer the same trigger for those: when a recorded change is followed by the site or its devices
+dropping off, roll that change back automatically, or offer the Roll Back in the alert. Open
+questions: opt-in per site, since the operator made the change on purpose and may be mid-work; how
+long to wait after the change before treating a drop as caused by it; and telling a change-caused
+drop from an unrelated outage (ISP Health already separates ISP from local).
+
+## User setting: 12-hour or 24-hour clock, everywhere
+
+Times are formatted inline today and the two styles are mixed: about 30 server-side format strings
+use a 12-hour clock (`h:mm tt`) and about 120 use 24-hour (`HH:mm`), and roughly 18 JS files format
+times on their own (ApexCharts axes and tooltips, `toLocaleTimeString`, hand-built labels). Add a
+per-user preference (`IUserPreferences`, falling back to the install-wide value) for 12- or 24-hour,
+and route every displayed time through it.
+
+- **Server:** `TimeFormatHelper` holds the one time format (`FormatLocalDateTime` and friends, added
+  2026-10-31 for Change Control) and reads the preference; the inline `h:mm tt` / `HH:mm` strings in
+  C# and Razor move onto it. `CcFormat` already delegates there.
+- **JS:** one shared formatter module that chart and page scripts import (axis labels, tooltips,
+  table cells), fed the preference from Razor on page load, so a chart and the card beside it agree.
+- **Out of scope:** outbound notifications (alerts to email, Slack, and other channels) go to people
+  who are not signed-in users, so they keep the install default; logs, CSV/PDF exports, and API
+  responses keep fixed formats a machine can read.
+
+Open question: whether the same setting should choose the date order too (Oct 31 vs 31 Oct), since
+the formats are being centralized anyway.

scripts/build-codemirror-bundle.ps1

@@ -0,0 +1,38 @@
+# Rebuilds the vendored CodeMirror 6 bundle used by Change Control's YAML editor.
+# Output: src/NetworkOptimizer.Web/wwwroot/lib/codemirror/codemirror.bundle.js (+ LICENSE).
+# Needs Node and npm. Installs from scripts/codemirror-bundle/package-lock.json (every transitive
+# version pinned) with install scripts off, in a temp folder; nothing is installed into the repo.
+# After a rebuild, bump the ?v= on the bundle import in wwwroot/js/cc-editor.js.
+param([switch]$UpdateLock)
+$ErrorActionPreference = 'Stop'
+
+$repo = Split-Path -Parent $PSScriptRoot
+$pkgDir = Join-Path $PSScriptRoot 'codemirror-bundle'
+$out = Join-Path $repo 'src/NetworkOptimizer.Web/wwwroot/lib/codemirror'
+$work = Join-Path ([System.IO.Path]::GetTempPath()) "cm-bundle-$([guid]::NewGuid().ToString('N'))"
+New-Item -ItemType Directory -Force $work, $out | Out-Null
+
+Push-Location $work
+try {
+    Copy-Item (Join-Path $pkgDir 'package.json'), (Join-Path $pkgDir 'entry.js') .
+    if ($UpdateLock -or -not (Test-Path (Join-Path $pkgDir 'package-lock.json'))) {
+        npm install --package-lock-only --ignore-scripts --no-audit --no-fund | Out-Null
+        Copy-Item package-lock.json (Join-Path $pkgDir 'package-lock.json')
+    }
+    else {
+        Copy-Item (Join-Path $pkgDir 'package-lock.json') .
+    }
+    npm ci --ignore-scripts --no-audit --no-fund | Out-Null
+    # esbuild's binary comes from an optional platform package, which ci installs without scripts.
+    npx --no-install esbuild entry.js --bundle --format=esm --minify --legal-comments=eof --outfile=bundle.js
+    $pkg = Get-Content package.json -Raw | ConvertFrom-Json
+    $versions = ($pkg.dependencies.PSObject.Properties | Where-Object Name -ne 'esbuild' | ForEach-Object { "$($_.Name)@$($_.Value)" }) -join ', '
+    $header = "/* CodeMirror 6 bundle for Change Control (MIT; licenses at the end and in LICENSE). Built by scripts/build-codemirror-bundle.ps1 from: $versions */`n"
+    Set-Content -Path (Join-Path $out 'codemirror.bundle.js') -Value ($header + (Get-Content bundle.js -Raw)) -Encoding utf8 -NoNewline
+    Copy-Item node_modules/codemirror/LICENSE (Join-Path $out 'LICENSE')
+}
+finally {
+    Pop-Location
+    Remove-Item -Recurse -Force $work
+}
+Get-Item (Join-Path $out 'codemirror.bundle.js') | Select-Object Name, Length

scripts/codemirror-bundle/entry.js

@@ -0,0 +1,12 @@
+// What cc-editor.js imports from the bundle. Add an export here, then rebuild.
+export { EditorView, keymap, hoverTooltip, Decoration, WidgetType, ViewPlugin, MatchDecorator, gutter, GutterMarker } from '@codemirror/view';
+export { EditorState, Compartment, StateEffect, StateField, Prec, RangeSetBuilder, Text } from '@codemirror/state';
+export { basicSetup } from 'codemirror';
+export { indentWithTab } from '@codemirror/commands';
+export { indentUnit, syntaxHighlighting, HighlightStyle, syntaxTree, codeFolding, foldEffect, unfoldEffect, foldedRanges } from '@codemirror/language';
+export { autocompletion, completionKeymap, startCompletion, closeCompletion, completionStatus, currentCompletions, setSelectedCompletion } from '@codemirror/autocomplete';
+export { linter, setDiagnostics, lintGutter } from '@codemirror/lint';
+export { openSearchPanel } from '@codemirror/search';
+export { Chunk } from '@codemirror/merge';
+export { yaml } from '@codemirror/lang-yaml';
+export { tags } from '@lezer/highlight';