Repository navigation
Visualizer3D: a resource moved back to where the scene placed it publishes that location - #1565
Merged
Merged
Conversation
…ishes that location _placed_as_kept dropped a location equal to the kept scene's, which is right only while the resource has not moved since the scene was built. A resource that moved away and back left every client drawing it where it had moved to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BioCam
marked this pull request as ready for review
October 30, 2026 14:07
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Viewer3D._placed_as_keptdrops a location update when it equals where the kept scene placed the resource. That only holds while the resource has not moved since the scene was built: once it has moved, the clients draw it somewhere else, so its return to the kept place is a real move. The update was dropped anyway, and every client kept drawing the resource where it had moved to. A device's Z column that lowered and came back up to its starting height stayed drawn lowered.PR Content
_placed_as_keptreturns False for a resource in_moved(moved since the scene was built), so its return to the kept place is published like any other move.server_tests.py: a plate moved away and back publishes its original location to the client.🤖 Generated with Claude Code