Repository navigation
PreciseFlex wire tests cleanup: build the setup lists from one list - #1579
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The PreciseFlex wire tests spell out the same setup commands four times:
_SETUP,_SETUP_SKIP_HOMEand_RAIL_SETUPinwire_tests.py, and_SETUP_WITHOUT_VISIONinvision_wire_tests.py._RAIL_SETUPis identical to_SETUP. A change to what setup sends has to be repeated in all four.PR Content/Solution
wire_tests.py:_SETUPand_SETUP_SKIP_HOMEare built from_SETUP_BEFORE_HOMEand_SETUP_AFTER_HOME.wire_tests.py:_RAIL_SETUPis removed, andtest_setup_with_railchecks against_SETUP.vision_wire_tests.py:_SETUP_WITHOUT_VISIONis built from_SETUPinwire_tests.py.Every list holds the same commands as before, and no driver code changes.
🤖 Generated with Claude Code