Skip to content

Prepare for Vision Integration - #13

Merged
guyfleeman merged 1 commit into
mainfrom
dev/will/prep_vision_integration
Aug 25, 2026
Merged

guyfleeman merged 1 commit into
mainfrom
dev/will/prep_vision_integration

Conversation

@guyfleeman

Copy link
Copy Markdown
Collaborator

Integration with vision processor revealed some things that can be cleaned up.

Issues:

  • Calling protoc on the default gc/ folder produces a path conflict Python's garbage collector always imports as gc, and this isn't fixable as the interpreter intrinsic always resolved first.
  • Defautl protoc cmake function clobbers the include path with used from subfolders/submodules because OUT_DIR internally prepends the output path. Was fixed in A-Team's ssl_ros_bridge FOSS project, but that logic became duplicative with vision processor

Fixes:

  • Renames the gc/ folder to gamecontoller. This is reflection but not wire breaking. Resolved the intrinsic path conflict with python garbage collector
  • Provides a python helper and documentation to put generate and contain protos in a sslproto module scoping imports and putting them on the path
  • Provides an importable cmake helper function that calls protoc in a way that doesn't clobber the import path for cmake c/cpp projects

@guyfleeman guyfleeman self-assigned this Aug 23, 2026
@guyfleeman

Copy link
Copy Markdown
Collaborator Author

Making a note, the reflection breaking is expected from the rename. Wire compat is preserved.

@guyfleeman
guyfleeman requested a review from lixfel August 23, 2026 20:00
@guyfleeman

Copy link
Copy Markdown
Collaborator Author

Cmake is tested downstream on a vision processor branch and the A-Team ssl_ros_bridge repo and seems to be working cleanly. The python is used on the same vp downstream and the internal wireshark and seems to working

@guyfleeman
guyfleeman merged commit 41ee8bb into main Aug 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants