Skip to content

Update defaults and driver list - #15

Merged
lixfel merged 2 commits into
dev/vision-processorfrom
vp-defaults
Nov 8, 2026
Merged

lixfel merged 2 commits into
dev/vision-processorfrom
vp-defaults

Conversation

@lixfel

@lixfel lixfel commented Nov 7, 2026

Copy link
Copy Markdown

No description provided.

@lixfel
lixfel requested a review from guyfleeman November 7, 2026 15:22
@lixfel lixfel self-assigned this Nov 7, 2026
@guyfleeman

Copy link
Copy Markdown
Collaborator

Acknowledging all breaking changes are isolated to the VPConfig subsystem, so that's our responsibility to deal with and not the teams so override of merge for those should be approved. I'll look into that failed test for dissector, looks like we might be getting throttled on the Nix check for CI. I'll look for a resolution on that.

@lixfel

lixfel commented Nov 7, 2026

Copy link
Copy Markdown
Author

Please be aware that this is targeting dev/vision-processor as the VPConfig system is not yet merged into main at all.

@guyfleeman

guyfleeman commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

In run_tests.py, you need to add "vision/ssl_vp_config.proto" to the PROTO_FILE array and then the dissector test will pass. We still expect the other two to fail because the changes are breaking. Maybe we should gate those runs to just main, or main and version branches or something.

@guyfleeman guyfleeman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking changes are only in vp config

@lixfel
lixfel merged commit 9d5ed61 into dev/vision-processor Nov 8, 2026
2 of 4 checks passed
@lixfel
lixfel deleted the vp-defaults branch November 8, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants