Repository navigation
initial commit of protocol dissector for wireshark - #7
Conversation
|
Will need to bypass protection rule then update since this adds a new CI target. It's incompatible with #8 until one of the two are merged |
lixfel
left a comment
lixfel
left a comment
There was a problem hiding this comment.
For my personal preference the code and dissector are a bit too verbose -- making them harder to read --, but that's just personal preference.
|
The comments, error messages, or code itself? I tried to write more detail since new teams may land here before anywhere else but if that missed the mark I actually think that's very important to fix. |
|
Yeah I think at least the README sections should be in a different order. Quick commands to compile/setup should be first and clean, deeper text for new teams should come later. Too clunky right now. I might merge this then PR a README improvement. |
Creates install targets and Lua wrapper to clearly decode all league packets in wireshark.
Adds convenience filter 'frame.protocols contains "ssl_"' that will eliminate all non-ssl messages.