Repository navigation
feat(Concentration): Overhauls mod with v1.1.0 features and UX - #2367
Open
steverobertsuk wants to merge 9 commits into
Open
steverobertsuk wants to merge 9 commits into
steverobertsuk wants to merge 9 commits into
Conversation
Version 1.1 is split into modules under src/, as the other Mods I maintain are, so it needs the same Rollup build, version bump and Prettier setup. sync-locales waits longer between Google Translate requests than the other Mods' copies, as the shorter waits were refused with HTTP 429. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
Ending concentration posted nothing, so the last line in chat was often the earlier "is now concentrating on" message, which read as if ending had started it again. Every way concentration ends now says so, and on which spell, and naming a different spell switches to it. The rewrite also fixes players' Roll buttons acting on their selected token, damage compared as text, unlinked tokens sharing a marker, the One-Click settings never being read, and spell cards marking characters the sender does not control. Chat output uses the card style of the other Mods, and the text is translated into 24 languages. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
The tests run the Mod against a Roll20 stub, so start, switch, end, saves, sheet detection and migration from version 1.0 can be checked without a game. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
The README, changelog and new developer, file map and testing guides follow the layout of the other Mods. The old docs folder is replaced by TESTING.md and the README's troubleshooting section. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
The 1.1.0 folder holds the same build as Concentration.js. script.json lists the new settings for the One-Click page and the handout and token permissions the Mod now uses. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…he Journal The Help and Command Deck handouts now use the plain Concentration icon from Roll20's file store as their journal icon (the handout avatar). The icon is set when a handout is created and added to handouts from earlier versions, so existing games get it too. Roll20 stores the avatar as max.webp with a number, so a handout counts as having the icon when its avatar contains the image's path. Only the webp files exist (thumb.png is a 404), so the URL uses thumb.webp. A test covers new handouts and handouts made before. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
The root script and the 1.1.0 snapshot are rebuilt without a version bump and remain identical. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…e handout Roll20 always stores a handout's journal icon as the full-size file, whatever size the Mod asks for, and shows that file at its natural size at the top of an open handout. The Concentration icon was a 1024 pixel upload, so it filled the handout above the text. The icon now points at a 100 pixel copy of the same artwork. Handouts from earlier builds are matched on the image path, so they change to the small icon the next time the Mod starts. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
The built script and its 1.1.0 copy carry the new icon path. The version number is unchanged. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release significantly overhauls the Concentration mod, rewriting its core into ES modules with modern development tooling. It introduces a host of new features and user experience improvements, alongside comprehensive test coverage and translations into 24 languages. Version 1.0 settings, macros, and commands remain fully compatible.
Fixed:
send_reminder_to: characternow correctly uses the character's full name and includes a copy for the GM.charnameappeared beforename.Added:
end,status,help, andjournal.globalThis.Concentration) for other Mods, offeringisConcentrating,spellOf,start,end, andlistmethods.Security:
Changed:
resetcommand now prompts for confirmation and preserves existing concentration records.src/and bundled using Rollup.docs/) has been integrated intoREADME.md,TESTING.md, andDEVELOPERS.md.Signed-off-by: Steve Roberts steve@shadowcomputers.co.uk