Repository navigation
fix(partial-instance-variable): ignore non-code at-rules - #467
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
efegokdemir
force-pushed
the
codex/fix-partial-instance-variable-comments-315
branch
from
October 2, 2026 14:50
6ad3a99 to
f685695
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #315.
Limit PartialInstanceVariable to active ERB code instead of scanning raw partial text. ERB comments are ignored, and CSS or HTML at-rules such as @font-face no longer produce false positives.
Tests
ruby -c lib/erb_lint/linters/partial_instance_variable.rb— passed.ruby -c spec/erb_lint/linters/partial_instance_variable_spec.rb— passed.git diff --check— passed.RSpec remains unverified. The system Ruby is 2.6.10 and cannot satisfy this checkout's dependencies; the installed Homebrew Ruby is 4.0.7, but the lockfile's minitest 5.25.4 requires Ruby <4.0. Bundler also reported other lockfile gems missing. I did not modify Gemfile or Gemfile.lock.