Repository navigation
Resolve inherited gem configs from Bundler - #468
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440
When an inherited gem is sourced from Git, RubyGems lookup can fail even though Bundler has resolved the gem. Fall back to Bundler’s resolved specs so
inherit_gemcan locate the config while preserving existing RubyGems lookup behavior.Adds a regression test that loads an inherited config from the Bundler-resolved gem path.
Tests:
bundle exec rspec(529 examples, 0 failures, 1 existing pending; run with a temporary Ruby 4.0-compatible dependency resolution because the locked Minitest 5.25.4 does not support the available Ruby 4.0. The repository lockfile is unchanged.)bundle exec rubocop lib/erb_lint/runner_config_resolver.rb spec/erb_lint/runner_config_spec.rb(clean)git diff --check