Skip to content

fix: handle RuboCop global offenses - #469

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-global-rubocop-errors
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-global-rubocop-errors

Conversation

@efegokdemir

Copy link
Copy Markdown

RuboCop global offenses use a PseudoSourceRange with begin_pos/end_pos rather than begin/end, which caused ERBLint to raise NoMethodError. Normalise source-position ranges before building the ERBLint location, and cover RuboCop's NO_LOCATION with a regression test. The test failed before the fix; bundle exec rspec passes (529 examples, 1 pending) and bundle exec rubocop passes (98 files). Fixes #420.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception on global Rubocop errors

1 participant