Skip to content

Fix glob exclusions for direct directory children - #471

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-glob-exclusion-patterns
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/fix-glob-exclusion-patterns

Conversation

@efegokdemir

Copy link
Copy Markdown

The **/app/components/**/* exclusion missed files directly inside the directory. Exclusions now also use FNM_PATHNAME matching, while retaining existing glob behaviour. Added regression coverage for direct children and nested files. Verified with the full RSpec suite (531 examples, 0 failures, 1 pending) and RuboCop (97 files, no offences). Fixes #265.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: the exclusion pattern **/* does not work as expected

1 participant