Skip to content

fix(rubocop): keep autocorrect inside ERB tags - #472

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/rubocop-autocorrect-erb-tags
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/rubocop-autocorrect-erb-tags

Conversation

@efegokdemir

Copy link
Copy Markdown

RuboCop autocorrect can return replacement ranges outside an ERB Ruby block, removing a template delimiter as reported in #383. This checks that each replacement stays within the block and adds a regression spec. The full RSpec suite passed (529 examples, 1 pending; run with task-local dependencies because the locked Minitest version does not support Ruby 4.0.5). RuboCop 1.84.2 passed on the changed files; its full run reports two offences in unchanged files.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant