Repository navigation
fix(layout): exclude items at viewport end - #2534
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2533 in
@shopify/flash-list.getVisibleLayoutsnow excludes trailing layouts whose leading edge is at the end of a non-empty viewport, including all cells in a boundary grid row. Zero-size viewport and partial-visibility behaviour are covered by regression tests.Validation passed: Jest (15 suites, 204 tests), lint, type-check, and build. The vertical and horizontal regression tests failed before the fix and pass now.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Not applicable.