Repository navigation
embed: QueryModel moves into mcp-kit (0.7.0) - #22
Merged
Merged
Conversation
shtse8
enabled auto-merge (squash)
October 2, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves lockdocs' query-side embedder into
mcp_kit::embedso there is one owner of the WordPiece and identifier splitting.embed::QueryModel(open(dir),embed(text)): reads only the vocabulary and the rows of the query's own tokens with positioned reads; same vector asModel::embedunderTokenization::Identifiers.ModelandQueryModelnow share onewordpieceroutine, oneidentifier_words, oneFxhasher.query_model_matches_the_full_model(moved from lockdocs, plus a truncated-file case).Checks: cargo test --workspace --locked --all-features, clippy -D warnings. Needs review; not armed.