Repository navigation
Conversation
buchmarv
requested changes
Nov 3, 2026
buchmarv
left a comment
buchmarv
left a comment
Contributor
There was a problem hiding this comment.
Please add a test case starting with / as this is what's fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author fields like website, LinkedIn or Xing are plain inputs, and the website field even validates as a domain name, so values like www.example.com are common. SchemaUtility resolved those against the current page (https://site/some/page/www.example.com), which broke sameAs, url and @id in the Person JSON-LD. The author partial printed them as relative links that end in a 404.
URLs without a scheme now get https://, in the schema via SchemaUtility::getAbsoluteUrl(), in the template via f:uri.external. Values starting with / still resolve against the host.