Repository navigation
test(*): resolve 'require-await' warnings in test files - #295
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The changes affect test callbacks, and no concrete regression is established; no PR-specific issue remains to resolve before merging. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: resolving require-await warnings in test files. |
| Description check | |
The description explains the changes and motivation, completes all required checklist items, reports testing, and identifies the change as dev-only with no release impact. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
View your CI Pipeline Execution ↗ for commit 91723ea
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
🎯 Changes
Resolve all
@typescript-eslint/require-awaitwarnings in thetestsdirectories ofpacer,alpine-pacer,lit-pacer,svelte-pacer, andvue-pacer.asyncfunctions withoutawaitwith functions that return a promise directly:return value→return Promise.resolve(value)throw error→return Promise.reject(error), so errors stay rejections instead of becoming synchronous throwsPromise.resolve(), so they still go through the async code pathPromise, so runtime behavior and the inferred types checked byexpectTypeOfare unchanged.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit