Skip to content

chore({vue-pacer,vue-pacer-devtools}): add 'eslint-plugin-vue' 'flat/recommended' config - #300

Merged
sukvvon merged 1 commit into
mainfrom
chore/vue-pacer-eslint-plugin
Oct 25, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/vue-pacer-eslint-plugin

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Add eslint-plugin-vue's flat/recommended config to vue-pacer and vue-pacer-devtools. Both packages support Vue 3 only, so this uses the Vue 3 preset instead of the version-agnostic flat/base.

  • Add eslint-plugin-vue and vue-eslint-parser, a required peer of the plugin, as devDependencies.
  • Turn off vue/one-component-per-file only where multiple components per file are intentional:
    • vue-pacer: tests/**
    • vue-pacer-devtools: src/VuePacerDevtools.tsx, which defines the panel and its no-op variant.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated development checks to include Vue-specific linting rules, with exceptions for certain component and test files.
    • Updated the development tooling used to support these checks. These changes do not alter end-user functionality.

@sukvvon sukvvon self-assigned this Oct 23, 2026
@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 63407d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedvue-eslint-parser@​10.4.19910010086100
Addedeslint-plugin-vue@​10.11.1991009196100

View full report

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between d9f55be and 63407d0.

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 4
  • packages/vue-pacer-devtools/eslint.config.js
  • packages/vue-pacer-devtools/package.json
  • packages/vue-pacer/eslint.config.js
  • packages/vue-pacer/package.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Both Vue packages add Vue ESLint’s flat recommended rules and the required development dependencies. Each package also disables vue/one-component-per-file for a specified set of files.

Changes: Vue ESLint Configuration

Layer / File(s) Summary
Add Vue lint rules to package configs
packages/vue-pacer/package.json, packages/vue-pacer-devtools/package.json, packages/vue-pacer/eslint.config.js, packages/vue-pacer-devtools/eslint.config.js
Both packages add eslint-plugin-vue and vue-eslint-parser as development dependencies and include the Vue plugin’s flat recommended rules. The configs disable vue/one-component-per-file for tests/** in Vue Pacer and src/VuePacerDevtools.tsx in Vue Pacer Devtools.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: kevinvandy

Merge Risk: ⚪ Minimal · up to 63407

No actionable merge-blocking risk was found in this configuration-only change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: adding eslint-plugin-vue's flat/recommended config to the vue-pacer and vue-pacer-devtools packages. It uses the conventional commit form and lists both affected packa…
Description check Passed The description follows the template sections: Changes, Checklist, and Release Impact. The Changes section explains the Vue 3 preset choice, the added devDependencies, and the per-file rule overrides …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: adding eslint-plugin-vue's flat/recommended config to the vue-pacer and vue-pacer-devtools packages. It uses the conventional commit form and lists both affected packages. The title is specific and matches the changeset.

Full details: Description check

Explanation

The description follows the template sections: Changes, Checklist, and Release Impact. The Changes section explains the Vue 3 preset choice, the added devDependencies, and the per-file rule overrides for both packages. The checklist and release impact are filled in. The description is complete and specific.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloud Bot commented Oct 23, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 63407d0

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 16:42:18 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-pacer

npm i https://pkg.pr.new/@tanstack/alpine-pacer@300

@tanstack/angular-pacer

npm i https://pkg.pr.new/@tanstack/angular-pacer@300

@tanstack/angular-pacer-devtools

npm i https://pkg.pr.new/@tanstack/angular-pacer-devtools@300

@tanstack/ember-pacer

npm i https://pkg.pr.new/@tanstack/ember-pacer@300

@tanstack/lit-pacer

npm i https://pkg.pr.new/@tanstack/lit-pacer@300

@tanstack/octane-pacer

npm i https://pkg.pr.new/@tanstack/octane-pacer@300

@tanstack/pacer

npm i https://pkg.pr.new/@tanstack/pacer@300

@tanstack/pacer-devtools

npm i https://pkg.pr.new/@tanstack/pacer-devtools@300

@tanstack/pacer-lite

npm i https://pkg.pr.new/@tanstack/pacer-lite@300

@tanstack/preact-pacer

npm i https://pkg.pr.new/@tanstack/preact-pacer@300

@tanstack/preact-pacer-devtools

npm i https://pkg.pr.new/@tanstack/preact-pacer-devtools@300

@tanstack/react-pacer

npm i https://pkg.pr.new/@tanstack/react-pacer@300

@tanstack/react-pacer-devtools

npm i https://pkg.pr.new/@tanstack/react-pacer-devtools@300

@tanstack/solid-pacer

npm i https://pkg.pr.new/@tanstack/solid-pacer@300

@tanstack/solid-pacer-devtools

npm i https://pkg.pr.new/@tanstack/solid-pacer-devtools@300

@tanstack/svelte-pacer

npm i https://pkg.pr.new/@tanstack/svelte-pacer@300

@tanstack/svelte-pacer-devtools

npm i https://pkg.pr.new/@tanstack/svelte-pacer-devtools@300

@tanstack/vue-pacer

npm i https://pkg.pr.new/@tanstack/vue-pacer@300

@tanstack/vue-pacer-devtools

npm i https://pkg.pr.new/@tanstack/vue-pacer-devtools@300

commit: 63407d0

@sukvvon
sukvvon merged commit 342ed13 into main Oct 25, 2026
12 checks passed
@sukvvon
sukvvon deleted the chore/vue-pacer-eslint-plugin branch October 25, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant