You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add eslint-plugin-vue's flat/recommended config to vue-pacer and vue-pacer-devtools. Both packages support Vue 3 only, so this uses the Vue 3 preset instead of the version-agnostic flat/base.
Add eslint-plugin-vue and vue-eslint-parser, a required peer of the plugin, as devDependencies.
Turn off vue/one-component-per-file only where multiple components per file are intentional:
vue-pacer: tests/**
vue-pacer-devtools: src/VuePacerDevtools.tsx, which defines the panel and its no-op variant.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Reviewing files that changed from the base of the PR and between d9f55be and 63407d0.
⛔ Files ignored due to path filters: 1
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 4
packages/vue-pacer-devtools/eslint.config.js
packages/vue-pacer-devtools/package.json
packages/vue-pacer/eslint.config.js
packages/vue-pacer/package.json
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
📝 Walkthrough
Both Vue packages add Vue ESLint’s flat recommended rules and the required development dependencies. Each package also disables vue/one-component-per-file for a specified set of files.
Both packages add eslint-plugin-vue and vue-eslint-parser as development dependencies and include the Vue plugin’s flat recommended rules. The configs disable vue/one-component-per-file for tests/** in Vue Pacer and src/VuePacerDevtools.tsx in Vue Pacer Devtools.
No actionable merge-blocking risk was found in this configuration-only change.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the main change: adding eslint-plugin-vue's flat/recommended config to the vue-pacer and vue-pacer-devtools packages. It uses the conventional commit form and lists both affected packa…
Description check
The description follows the template sections: Changes, Checklist, and Release Impact. The Changes section explains the Vue 3 preset choice, the added devDependencies, and the per-file rule overrides …
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: adding eslint-plugin-vue's flat/recommended config to the vue-pacer and vue-pacer-devtools packages. It uses the conventional commit form and lists both affected packages. The title is specific and matches the changeset.
Full details: Description check
Explanation
The description follows the template sections: Changes, Checklist, and Release Impact. The Changes section explains the Vue 3 preset choice, the added devDependencies, and the per-file rule overrides for both packages. The checklist and release impact are filled in. The description is complete and specific.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Add
eslint-plugin-vue'sflat/recommendedconfig tovue-pacerandvue-pacer-devtools. Both packages support Vue 3 only, so this uses the Vue 3 preset instead of the version-agnosticflat/base.eslint-plugin-vueandvue-eslint-parser, a required peer of the plugin, as devDependencies.vue/one-component-per-fileonly where multiple components per file are intentional:vue-pacer:tests/**vue-pacer-devtools:src/VuePacerDevtools.tsx, which defines the panel and its no-op variant.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit