Repository navigation
chore(svelte-pacer): add 'eslint-plugin-svelte' to lint '.svelte' files - #301
Conversation
|
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
|
View your CI Pipeline Execution ↗ for commit 73b7e8a
☁️ Nx Cloud last updated this comment at |
Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title names the main change: adding eslint-plugin-svelte to lint .svelte files in svelte-pacer. The changeset adds an ESLint config for Svelte files and the two devDependencies that support it. Th… |
| Description check | |
The description follows the template. It has a Changes section that explains the change and its motivation, using the same config as svelte-pacer-devtools. It lists the parser, the svelte/block-lang a… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title names the main change: adding eslint-plugin-svelte to lint .svelte files in svelte-pacer. The changeset adds an ESLint config for Svelte files and the two devDependencies that support it. The title uses the conventional chore(...) prefix, which fits a dev-only change. It is 71 characters, within a typical limit.
Full details: Description check
-
Explanation
The description follows the template. It has a Changes section that explains the change and its motivation, using the same config as svelte-pacer-devtools. It lists the parser, the svelte/block-lang and svelte/no-svelte-internal rules, and the added devDependencies. The checklist items are filled in. The release impact section marks the change as docs/CI/dev-only with no changeset, which matches the scope of a dev-only lint change. The description does not state which tests ran with pnpm run test:pr, but the checklist covers that item.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments: 2
packages/svelte-pacer/eslint.config.js: 1
3-4: LGTM!Also applies to: 7-31
packages/svelte-pacer/package.json: 1
124-125:Trivial · Security & Privacy · Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Pin the new lint dependencies to exact versions.
A non-frozen install can select later minor or patch releases from these caret ranges. Both packages run as development tooling. Exact pins make tooling updates deliberate. (docs.npmjs.com)
Based on learnings, security-sensitive development tooling should use exact version pins rather than caret ranges.
Source: Learnings
-
-
- Source mode: Auto
- Repository: TanStack/pacer
- Branch: chore/svelte-pacer-eslint-plugin
- File: .coderabbit.yaml
- Commit: 73b7e8a
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
d4e500bf-282f-4744-8efb-381b6cd62c97
-
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
-
packages/svelte-pacer/eslint.config.jspackages/svelte-pacer/package.json
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
🎯 Changes
Add
eslint-plugin-svelte'srecommendedconfig tosvelte-pacerso that.svelteand.svelte.tsfiles are linted, using the same config assvelte-pacer-devtools..svelte,.svelte.tsand.svelte.jsfiles with@typescript-eslint/parserand the package'ssvelte.config.js.lang="ts"in script blocks (svelte/block-lang) and forbidsvelte/internalimports (svelte/no-svelte-internal).eslint-plugin-svelteand@typescript-eslint/parseras devDependencies.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit