Repository navigation
Update tgfx to 35be4ca for the SVG import CSS class style fix. - #3768
Merged
Merged
Conversation
fengdyli
requested review from
Hparty,
domchen,
kevingpqi123 and
shlzxjp
as code owners
October 15, 2026 08:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
+ Coverage 83.50% 83.53% +0.03%
==========================================
Files 731 731
Lines 105532 105532
Branches 29218 29218
==========================================
+ Hits 88122 88155 +33
+ Misses 10806 10797 -9
+ Partials 6604 6580 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shlzxjp
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump tgfx from
c9565633to35be4ca2d(current tgfx main). It brings two commits:7d16bd9— Fix CSS class styles lost in SVG import for grouped selectors, duplicate rules, and text fragments (PAG 时间伸缩 #1594)35be4ca— Expose vector element types for external format conversion (报错 #1597)The first one is the reason for this bump: when an SVG declares styles with grouped selectors (e.g.
.cls-1, .cls-2, .cls-3 { fill: none }), those declarations were dropped entirely, so fills / strokes / font-family went missing on import.Compatibility
SVGTextContainer::getTextChildren()togetChildren()and widens the element type. That API is only used inside tgfx's SVG module — libpag does not reference it, so no libpag-side change is needed.VectorElement::Type/type()fromprotectedtopublic(additive).Test plan
depsyncpicks up tgfx 35be4ca and builds libpag against it).