Skip to content

Update tgfx to 35be4ca for the SVG import CSS class style fix. - #3768

Merged
shlzxjp merged 1 commit into
mainfrom
feature/fengdyli_update_tgfx_35be4ca
Oct 15, 2026
Merged

shlzxjp merged 1 commit into
mainfrom
feature/fengdyli_update_tgfx_35be4ca

Conversation

@fengdyli

Copy link
Copy Markdown
Collaborator

Bump tgfx from c9565633 to 35be4ca2d (current tgfx main). It brings two commits:

  • 7d16bd9 — Fix CSS class styles lost in SVG import for grouped selectors, duplicate rules, and text fragments (PAG 时间伸缩 #1594)
  • 35be4ca — Expose vector element types for external format conversion (报错 #1597)

The first one is the reason for this bump: when an SVG declares styles with grouped selectors (e.g. .cls-1, .cls-2, .cls-3 { fill: none }), those declarations were dropped entirely, so fills / strokes / font-family went missing on import.

Compatibility

  • PAG 时间伸缩 #1594 renames SVGTextContainer::getTextChildren() to getChildren() and widens the element type. That API is only used inside tgfx's SVG module — libpag does not reference it, so no libpag-side change is needed.
  • 报错 #1597 only moves VectorElement::Type / type() from protected to public (additive).
  • No tgfx public API is removed in this range.

Test plan

  • CI on all platforms (depsync picks up tgfx 35be4ca and builds libpag against it).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.53%. Comparing base (7fe2ad9) to head (a93e8b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3768      +/-   ##
==========================================
+ Coverage   83.50%   83.53%   +0.03%     
==========================================
  Files         731      731              
  Lines      105532   105532              
  Branches    29218    29218              
==========================================
+ Hits        88122    88155      +33     
+ Misses      10806    10797       -9     
+ Partials     6604     6580      -24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shlzxjp
shlzxjp merged commit 7cb58c1 into main Oct 15, 2026
8 checks passed
@shlzxjp
shlzxjp deleted the feature/fengdyli_update_tgfx_35be4ca branch October 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants