Repository navigation
deps: pin brotli4j to 1.24.0 in service parent - #2780
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency overrides are consistent, correctly scoped to service models, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Pins Brotli4j to 1.24.0 in the standalone service parent to address the reported security alerts. The override applies to model services, not the solver library.
Changes:
- Adds a shared Brotli4j version property.
- Overrides the Quarkus BOM version for Brotli4j and five Linux, macOS, and Windows native artifacts.
| File | Description |
|---|---|
| service/facade/service-parent/pom.xml | Manages Brotli4j and selected native artifacts at version 1.24.0. |
Review effort: Balanced
Christopher-Chianelli
approved these changes
Oct 27, 2026
Christopher-Chianelli
left a comment
Contributor
There was a problem hiding this comment.
Windows build fails due to unrelated issue. LGTM (although I would maybe add a TODO to remove the overrides when Quarkus updates the version).
rsynek
force-pushed
the
chore/brotli4j-1.24.0
branch
from
October 27, 2026 15:29
f6fa2db to
e9b6dd3
Compare
rsynek
approved these changes
Oct 27, 2026
rsynek
left a comment
Contributor
There was a problem hiding this comment.
OK to merge if there are no other ways of securing the solver-service, e.g. by disabling the decompression algorithm.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin
com.aayushatharva.brotli4j(brotli4j, plus the linux/osx/windows x86_64 and aarch64 natives) to 1.24.0 intimefold-solver-service-parent. Quarkus BOM 3.40.1 manages 1.23.0, which Aikido flags (AIKIDO-2026-717109, AIKIDO-2026-27936).timefold-solver-service-parenthas no parent. Its owndependencyManagementgoverns every model service, so the pin goes there. The solver library is not affected.mvn -Ptest-model -pl service/test-model dependency:tree -Dincludes=com.aayushatharva.brotli4jBefore:
After:
Not verified: the linux natives do not appear in the tree on macOS.
help:effective-pomshows them managed at 1.24.0.