Skip to content

deps: pin brotli4j to 1.24.0 in service parent - #2780

Merged
rsynek merged 1 commit into
mainfrom
chore/brotli4j-1.24.0
Oct 27, 2026
Merged

rsynek merged 1 commit into
mainfrom
chore/brotli4j-1.24.0

Conversation

@jennedebleser

Copy link
Copy Markdown
Contributor

Pin com.aayushatharva.brotli4j (brotli4j, plus the linux/osx/windows x86_64 and aarch64 natives) to 1.24.0 in timefold-solver-service-parent. Quarkus BOM 3.40.1 manages 1.23.0, which Aikido flags (AIKIDO-2026-717109, AIKIDO-2026-27936).

timefold-solver-service-parent has no parent. Its own dependencyManagement governs every model service, so the pin goes there. The solver library is not affected.

mvn -Ptest-model -pl service/test-model dependency:tree -Dincludes=com.aayushatharva.brotli4j

Before:

\- com.aayushatharva.brotli4j:brotli4j:jar:1.23.0:compile
   +- com.aayushatharva.brotli4j:service:jar:1.23.0:compile
   \- com.aayushatharva.brotli4j:native-osx-aarch64:jar:1.23.0:compile

After:

\- com.aayushatharva.brotli4j:brotli4j:jar:1.24.0:compile
   +- com.aayushatharva.brotli4j:service:jar:1.24.0:compile
   \- com.aayushatharva.brotli4j:native-osx-aarch64:jar:1.24.0:compile

Not verified: the linux natives do not appear in the tree on macOS. help:effective-pom shows them managed at 1.24.0.

@jennedebleser
jennedebleser requested a review from a team October 26, 2026 14:51
Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency overrides are consistent, correctly scoped to service models, and have no identified blocking issues.

No open issues 🎉

What changed in this PR

Pins Brotli4j to 1.24.0 in the standalone service parent to address the reported security alerts. The override applies to model services, not the solver library.

Changes:

  • Adds a shared Brotli4j version property.
  • Overrides the Quarkus BOM version for Brotli4j and five Linux, macOS, and Windows native artifacts.
File Description
service/​facade/​service-parent/​pom.xml Manages Brotli4j and selected native artifacts at version 1.24.0.

Review effort: Balanced

@Christopher-Chianelli Christopher-Chianelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows build fails due to unrelated issue. LGTM (although I would maybe add a TODO to remove the overrides when Quarkus updates the version).

@rsynek
rsynek force-pushed the chore/brotli4j-1.24.0 branch from f6fa2db to e9b6dd3 Compare October 27, 2026 15:29
Copilot AI balanced review requested due to automatic review settings October 27, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The overrides use Maven dependency management correctly, share one version property, and remain scoped to model services.

No open issues 🎉

Review effort: Balanced

@rsynek rsynek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if there are no other ways of securing the solver-service, e.g. by disabling the decompression algorithm.

@rsynek
rsynek merged commit 11ee605 into main Oct 27, 2026
40 checks passed
@rsynek
rsynek deleted the chore/brotli4j-1.24.0 branch October 27, 2026 16:13

This branch was successfully deployed

1 active deployment
internal — e9b6dd32 Deployed Oct 27, 2026 by rsynek via approval_required #1118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants