Repository navigation
Fix EDF scheduler cancellation and state visibility - #6
Closed
yunuservices wants to merge 1 commit into
Closed
yunuservices wants to merge 1 commit into
yunuservices wants to merge 1 commit into
Conversation
Spottedleaf
reviewed
Feb 21, 2026
yunuservices
force-pushed
the
fix/scheduler-numa-cancel-state
branch
from
June 2, 2026 13:11
e8972be to
a951905
Compare
yunuservices
force-pushed
the
fix/scheduler-numa-cancel-state
branch
from
September 19, 2026 06:50
a951905 to
5348d20
Compare
yunuservices
changed the title
yunuservices
force-pushed
the
fix/scheduler-numa-cancel-state
branch
from
October 20, 2026 09:17
5348d20 to
0ca351a
Compare
Member
|
Thanks for the PR. These changes don't look correct but there appear to be some valid bugs here. Please open individual issues for each so they can be looked into. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few correctness issues in the EDF scheduler.
SchedulableTick.statevolatile, it was read without synchronizationEDFSchedulerThreadPool.schedule()when the start is not set, as documented inScheduler#scheduleEDFSchedulerThreadPool.cancel()so a task cancelled while its tick is running is not rescheduled