Skip to content

Change event of create_release workflow #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
urfeex wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change event of create_release workflow #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/create_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Create release

on:
pull_request:
# pull_request tokens are read-only for fork-based release PRs.
pull_request_target:

@cursor cursor Bot Nov 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title has grammar issues

Low Severity

The PR title Change event of create_release workflow omits articles and can be read as the noun phrase change event rather than a verb phrase. This violates the PR title rule requiring a meaningful title without grammar or spelling errors. A clearer title is Switch create_release workflow to pull_request_target.

Fix in Cursor Fix in Web

Triggered by team rule: PR title

Reviewed by Cursor Bugbot for commit a9b3876. Configure here.

types: [closed]
branches:
- master
Expand All @@ -18,6 +19,8 @@ jobs:

steps:
- uses: actions/checkout@v7
with:
ref: ${{ github.event.pull_request.merge_commit_sha }}

@cursor cursor Bot Nov 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fork release checkout will fail

High Severity

actions/checkout@v7 refuses ref: ${{ github.event.pull_request.merge_commit_sha }} on pull_request_target for fork PRs unless allow-unsafe-pr-checkout is set. The checkout step fails for the fork-based release PRs this change is meant to support, so the draft release is never created.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a9b3876. Configure here.


- name: Read version from package.xml
id: version
Expand Down
Loading