Skip to content

Install the wait_robot_booted.py script - #615

Merged
urfeex merged 1 commit into
UniversalRobots:masterfrom
urfeex:install_wait_robot_booted.py
Nov 4, 2026
Merged

urfeex merged 1 commit into
UniversalRobots:masterfrom
urfeex:install_wait_robot_booted.py

Conversation

@urfeex

@urfeex urfeex commented Nov 3, 2026

Copy link
Copy Markdown
Member

This way it can be started using ros2 run ...

This way it can be started using `ros2 run ...`
@urfeex
urfeex requested a review from a team November 3, 2026 20:31
@urfeex urfeex added the enhancement New feature or request label Nov 3, 2026
@urfeex
urfeex marked this pull request as ready for review November 3, 2026 20:31
Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:32
@cursor

cursor Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Packaging-only change; adds one script to the install manifest with no effect on built libraries or launch behavior.

Overview
Installs scripts/wait_robot_booted.py alongside the other helper scripts in the non-Catkin install path (lib/${PROJECT_NAME}), so packaged builds expose it as an executable entry point (e.g. ros2 run ...).

No runtime or library code changes—only the CMake install(PROGRAMS ...) list is extended.

Reviewed by Cursor Bugbot for commit f50f5bb. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change installing wait_robot_booted.py as a package executable.

No open issues 🎉

What changed in this PR

Installs wait_robot_booted.py with the package’s executable scripts so it can be launched using ros2 run.

Changes:

  • Adds scripts/wait_robot_booted.py to the CMake PROGRAMS installation list targeting lib/${PROJECT_NAME}.
File Description
CMakeLists.txt Includes wait_robot_booted.py in script installation.

Review effort: Balanced

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.87%. Comparing base (7057991) to head (f50f5bb).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   83.39%   83.87%   +0.47%     
==========================================
  Files         127      127              
  Lines        8388     8389       +1     
  Branches     3829     3829              
==========================================
+ Hits         6995     7036      +41     
+ Misses        981      945      -36     
+ Partials      412      408       -4     
Flag Coverage Δ
python_scripts 49.69% <ø> (ø)
start_ursim 92.50% <ø> (+0.29%) ⬆️
unit 61.60% <ø> (ø)
ur20-latest 81.05% <ø> (-0.03%) ⬇️
ur5-3.14.3 80.85% <ø> (+0.06%) ⬆️
ur5e-10.11.0 76.60% <ø> (ø)
ur5e-10.12.0 77.65% <ø> (+0.06%) ⬆️
ur5e-10.7.0 76.11% <ø> (-0.02%) ⬇️
ur5e-5.9.4 81.05% <ø> (+0.06%) ⬆️
ur7e-10.13.0 78.16% <ø> (+0.01%) ⬆️
ur7e-10.14.0 78.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@urfeex urfeex added this to the Next release milestone Nov 4, 2026
@mergify

mergify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@urfeex
urfeex merged commit 197600a into UniversalRobots:master Nov 4, 2026
100 of 104 checks passed
@urfeex
urfeex deleted the install_wait_robot_booted.py branch November 4, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants