Repository navigation
Data fixers - #5054
Merged
Merged
Data fixers#5054
Conversation
artemisSystem
force-pushed
the
datafixers
branch
4 times, most recently
from
October 11, 2026 17:01
ccf440a to
86fd511
Compare
Member
Author
|
Note to self: my retainer bouncer from 1.16 stopped working after a migration. investigate (tracked in #5061) |
artemisSystem
force-pushed
the
datafixers
branch
2 times, most recently
from
October 23, 2026 14:56
b3791db to
5431e98
Compare
Collaborator
|
Looking good to me in general. Fixer logic for the changes in 7269a9d needs to be added eventually, but could also happen in a later commit. The Block constants change should probably still be part of this PR, though. |
artemisSystem
force-pushed
the
datafixers
branch
from
November 1, 2026 13:48
5431e98 to
19d29fa
Compare
Member
Author
|
I think that's all the changes addressed. I'll do the blockPos changes in a separate commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's done (i hope)
Not everything makes sense to support fully. Limitations are detailed in the changelog.
As a general overview, these fixers mixin to some schemas to register types, some vanilla fixes to apply relevant botania ones, and into the DataFixers class itself to register some botania-specific fixers.
I'll have a look at recipe/advancement renames in the near future, they're not included in this PR.