Repository navigation
ci(windows-nightly): run only the PR-skipped tests; move on when a kill never confirms (#167) - #174
Merged
Merged
Conversation
…onfirms (#167) The 10-16 nightly: parity-brake (Node 22) and scorer (Node 24) printed their summaries, then bun never exited. The 5-minute limit fired, but the runner logged and moved on only after the process confirmed its exit, which never came, so both jobs sat until the 60-minute step limit. Now the runner logs HUNG the moment the limit hits, logs what taskkill reported, and moves on 15 s after the kill whether or not the exit arrives. The report says whether the file ran its tests and didn't exit, or didn't finish them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Every PR's windows job already runs the suite on Windows, except the 3 tests marked nightly-only (e2e, legacy-stamp-note, wjttc/hooks). The nightly re-ran all 156 files to reach them, and each extra file was another chance for bun to finish its tests and not exit: parity-brake, scorer and kernel-stress did on 10-16, all passing. Now the nightly runs only the files that use windowsPr (`--nightly-only`), so the release gate is those tests. Step limit 30 min, job 40. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Wolfe-Jam
changed the title
R7-4 starts the CLI 16 times; on this PR's Windows (Node 24) job a child hung there twice in a row (faf export --html, then faf loop), named by namedHang. That is the class the PR job leaves to the nightly, so it joins e2e, legacy-stamp-note and hooks there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #167. Follow-up to #172.
What the 10-16 nightlies showed
parity-brake(Node 22) andscorer(Node 24) printed their passing summaries, then bun never exited. NoHUNGline: the runner waited for an exit that never came.wasm/kernel-stressran 19/19 passing, then didn't exit; named at 5 min;taskkillsaid "could not be terminated … no running instance of the task"; the runner moved on 15 s later and finished in 8½ min.So #167 has a second shape: bun finishing a file's tests and not exiting. All three files load WASM (scoring kernel / FAFb), a lead, not proven.
Changes
scripts/test-per-file.mjs: logsHUNG (#167)the moment the limit hits; logs whattaskkill /T /Freported; moves on 15 s after the kill whether or not the exit arrives; the junit entry says ran its tests but did not exit or did not finish.--nightly-only: the files that usewindowsPr:e2e,commands/legacy-stamp-note,wjttc/hooks). Every PR'swindowsjob already runs the other 153 files on Windows (a failing test fails the PR; a stall warns), so the nightly no longer repeats them. The release gate (pubpro Step 1.1b) becomes: those tests green on Node 22. Step limit 60 → 30 min, job 75 → 40.Checked
node scripts/test-per-file.mjs --nightly-onlylocally: 3 files, 0 failed.🤖 Generated with Claude Code