Repository navigation
fix(taf): faf taf setup pins faf-taf-git v2.3.1 - #176
Merged
Merged
Conversation
The workflow written by `faf taf setup` pinned v2.2.0, two releases behind; v2.3.0 added the WJTTC parser. faf-cli's own CI already runs v2.3.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Dependabot bumps the uses: pin in ci.yml on each faf-taf-git release, but can't see FAF_TAF_GIT in src/commands/taf.ts. This test reads the CI pin and fails until taf.ts matches, so the Dependabot PR itself flags the drift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faf taf setupwrites a workflow that pinsWolfe-Jam/faf-taf-git@v2.2.0, two releases behind. v2.3.0 added the WJTTC parser; v2.3.1 is the latest release. faf-cli's own CI already runs v2.3.1.src/commands/taf.ts: the pin, v2.2.0 → v2.3.1.tests/commands/taf-setup.test.ts: the expected pin.ci.ymland checks thatfaf taf setupwrites the same one. Dependabot bumpsci.ymlon each faf-taf-git release but can't see the string intaf.ts, so from now on that Dependabot PR goes red untiltaf.tsis bumped too. Checked: a simulated bump to v2.4.0 fails the test.npm test -- tests/commands/taf-setup.test.ts: 8/8 pass.tsc --noEmitis clean.Merging publishes nothing. It ships with the next faf-cli release.
🤖 Generated with Claude Code