Repository navigation
docs: missing MoP area data and the fill-from defect - #822
Merged
Merged
Conversation
Six zones - Feralas, Felwood, Searing Gorge, Un'Goro, Mount Hyjal, Silithus - have no area/<id>.json on legacy_mop or mop, because SkyFire 5.4.8 carries a third of the spawns and a sixth of the flagged NPCs that TDB 4.3.4 has in them. The Cataclysm clients were rebuilt from 4.3.4 and do not have the gap; the Mists clients cannot switch, since 4.3.4 has no Pandaria. Records the --fill-from attempt and exactly where it broke: the merge reports adopting the six zones but writes them with gathering nodes and no NPCs, while the same dump run standalone against the same client places all of them. Also what was ruled out - grids, nesting, per-dump state - and the first hypothesis worth testing, so this does not have to be re-derived from scratch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes down the one thing left unresolved after #821, so it does not have to be re-derived.
Six zones — Feralas, Felwood, Searing Gorge, Un'Goro, Mount Hyjal, Silithus — have no
area/<id>.jsononlegacy_mop/mop. A missing file is silent:AreaDBlogs at Debug and the zone simply has no vendors, soAdhocNPCGoalnever fires there.docs/area-data-mop-gap.mdrecords:--fill-fromattempt and exactly where it broke — the merge reports adopting all six zones, but writes them with gathering nodes and no NPCs, while the same dump run standalone against the same client places every one of them.seen/skinnable/chests/npc_metaall per-dump.Linked from
scripts/CLAUDE.md, next to the rules #821 established, since that's where anyone regenerating area data will be reading.🤖 Generated with Claude Code