Skip to content

docs: missing MoP area data and the fill-from defect - #822

Merged
Xian55 merged 1 commit into
devfrom
docs/area-data-mop-gap
Aug 2, 2026
Merged

Xian55 merged 1 commit into
devfrom
docs/area-data-mop-gap

Conversation

@Xian55

@Xian55 Xian55 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Writes down the one thing left unresolved after #821, so it does not have to be re-derived.

Six zones — Feralas, Felwood, Searing Gorge, Un'Goro, Mount Hyjal, Silithus — have no area/<id>.json on legacy_mop/mop. A missing file is silent: AreaDB logs at Debug and the zone simply has no vendors, so AdhocNPCGoal never fires there.

docs/area-data-mop-gap.md records:

  • Cause — SkyFire 5.4.8 holds 1575 spawns and 13 flagged NPCs inside Feralas against 4721 and 74 in TDB 4.3.4. The Cataclysm clients were rebuilt from 4.3.4 and don't have the gap; the Mists clients can't switch, since 4.3.4 has no Pandaria.
  • The --fill-from attempt and exactly where it broke — the merge reports adopting all six zones, but writes them with gathering nodes and no NPCs, while the same dump run standalone against the same client places every one of them.
  • What was ruled out — grids present for both eras, nothing nested inside Feralas' rect, and seen/skinnable/chests/npc_meta all per-dump.
  • First hypothesis worth testing — that the fill's NPCs resolve into a zone the primary already covered, so whole-zone granularity discards them while their nodes land in a zone the primary lacked. If so, the fix is per-category merging within a zone rather than per zone.
  • Reproduction commands and the two dump filenames.

Linked from scripts/CLAUDE.md, next to the rules #821 established, since that's where anyone regenerating area data will be reading.

🤖 Generated with Claude Code

Six zones - Feralas, Felwood, Searing Gorge, Un'Goro, Mount Hyjal, Silithus -
have no area/<id>.json on legacy_mop or mop, because SkyFire 5.4.8 carries a
third of the spawns and a sixth of the flagged NPCs that TDB 4.3.4 has in them.
The Cataclysm clients were rebuilt from 4.3.4 and do not have the gap; the Mists
clients cannot switch, since 4.3.4 has no Pandaria.

Records the --fill-from attempt and exactly where it broke: the merge reports
adopting the six zones but writes them with gathering nodes and no NPCs, while
the same dump run standalone against the same client places all of them. Also
what was ruled out - grids, nesting, per-dump state - and the first hypothesis
worth testing, so this does not have to be re-derived from scratch.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Xian55
Xian55 merged commit da2fa6c into dev Aug 2, 2026
1 check passed
@Xian55
Xian55 deleted the docs/area-data-mop-gap branch August 2, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant