Repository navigation
[Automated] Draft docs (agentgateway): mcp: validate duplicate target names - #1446
Open
github-actions[bot] wants to merge 3 commits into
Open
github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
… names Drafts-Commit: 9e3deee Signed-off-by: GitHub Action <action@github.com>
Deploying agentproxy with
|
| Latest commit: |
948cead
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47faabc1.agentproxy.pages.dev |
| Branch Preview URL: | https://pr-tracker-draft-agentgatewa-0l98.agentproxy.pages.dev |
The release-notes entry for this change now lives in the combined release-notes PR, #1482, so the draft PRs no longer conflict on the release-notes pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Collaborator
|
Moved this PR's release-notes entry to the combined release-notes PR, #1482, so the draft PRs stop conflicting on the release-notes pages. Review or change the entry there. |
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#4160 — mcp: validate duplicate target names
Docs versions:
standalone/main,standalone/latest,kubernetes/main,kubernetes/latest(first shipped in v1.7.0)What changes for users: Standalone MCP target lists now reject duplicate
namevalues withduplicate mcp target name "<name>". Kubernetes service selectors now resolve duplicate generated MCP target names deterministically: static targets win over selected Services, and selected Service ties are broken by namespace, annotation use, creation time, and name.What the docs now say: The standalone MCP configuration modes page now says that
mcp.targetsandroutes[].backends[].mcp.targetsnames must be unique. The Kubernetes Virtual MCP page now explains how selector target-name collisions are resolved.Not verified: Configuration was not applied or run, and internal links are unchecked.
How
agentgateway-4160was drafted, and what was not verifiedPlan, and what changed it
neighbors/README.mdshowed nearby changes incrates/agentgateway/src/types/local.rs, but those changes cover environment-variable expansion and Gateway API defaults, not MCP target-name validation.Why a documentation change is necessary
The pull request adds standalone validation that rejects duplicate MCP target names, and
configuration-modes.mdalready explains where readers configure MCP targets. The pull request also changes Kubernetes selector translation to ignore lower-priority Services when generated target names collide, andmultiplex.mdalready teaches selector-based virtual MCP backends. Without this update, readers can create duplicate target names without knowing whether validation fails or which selected Service is used.I left
assets/agw-docs/pages/agentgateway/mcp/static.mdunchanged because that page covers fixed static andbackendReftargets, not selector-generated target names.What changed on disk
assets/agw-docs/pages/agentgateway/mcp/multiplex.md— Added a v1.7+ note about selector target-name collisions and the precedence order for the retained target.content/docs/standalone/latest/documentation/mcp/configuration-modes.md— Added standalone duplicate target-name validation behavior.content/docs/standalone/main/documentation/mcp/configuration-modes.md— Added the same standalone duplicate target-name validation behavior for main.How to verify this change
mcp.targetsthat use the samename, and runagentgateway --validate-only -f config.yaml. The command exits nonzero and reportsduplicate mcp target name "<name>".trustedand a selector that matches a Service annotated withagentgateway.dev/mcp-target-name: trusted.MCP target "trusted" from Service <namespace>/<name> conflicts with static target; ignored, and the generated backend keeps the statictrustedtarget.What was not verified
How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4160 — mcp: validate duplicate target names
agentgateway/websiteRelease notes
This pull request also adds its release-note entries:
content/docs/standalone/latest/release-notes/release-notes.md: mcp: validate duplicate target names (fix, under MCP)content/docs/standalone/main/release-notes/release-notes.md: mcp: validate duplicate target names (fix, under MCP)Release notes kept out of a tree. Check that each change really does not reach the trees named here:
kubernetes/main,kubernetes/latest, because the draft edited no page there. If the change also reaches that tree, add the note there.Draft branch:
pr-tracker-draft-agentgateway-4160