Repository navigation
[Automated] Draft docs (agentgateway): feat: report MCP request outcomes in metrics - #1447
Merged
Merged
Conversation
…mes in metrics Drafts-Commit: 9a568b4 Signed-off-by: GitHub Action <action@github.com>
The release-notes entry for this change now lives in the combined release-notes PR, #1482, so the draft PRs no longer conflict on the release-notes pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Collaborator
|
Moved this PR's release-notes entry to the combined release-notes PR, #1482, so the draft PRs stop conflicting on the release-notes pages. Review or change the entry there. |
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Resolve the dataplane.md conflict with #1450 by moving the outcome query row into #1450's existing version gate. Document each outcome value and its precedence (per mcp_outcome in log.rs), and add the label to the standalone MCP observability page and metrics reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Art Berger <art.berger@solo.io>
artberger
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#4182 — feat: report MCP request outcomes in metrics
Docs versions:
standalone/main,kubernetes/mainWhat changes for users: The
agentgateway_mcp_requests_totalmetric now has anoutcomelabel. Dashboards and alerts can distinguishsuccess,tool_error,protocol_error,gateway_error, andunknown, including tool errors that still return HTTP200.What the docs now say: The Kubernetes data plane metrics reference now documents the new
outcomelabel and adds a PromQL query that groups MCP tool calls byserver,resource, andoutcome. The standalone metrics reference also mentionsagentgateway_mcp_requests_total, but it was not in the authorized target list, so this report names that gap.Not verified: No cluster; the metrics query and configuration are unrun.
How
agentgateway-4182was drafted, and what was not verifiedPlan, and what changed it
assets/agw-docs/pages/observability/metrics/dataplane.md, and left the standalone metrics reference for reviewer follow-up.Why a documentation change is necessary
The pull request adds an
outcomelabel to theMCPCallmetric labels incrates/agentgateway/src/telemetry/metrics.rsand sets the value from request status, JSON-RPC errors, andtools/callresults incrates/agentgateway/src/telemetry/log.rs. The data plane metrics page already listsagentgateway_mcp_requests_totaland includes an MCP tool-call PromQL query, so a reader looking for MCP metric labels would not discover the new outcome dimension. The diff's tests define the expected values:success,tool_error,protocol_error,gateway_error, andunknown.What changed on disk
assets/agw-docs/pages/observability/metrics/dataplane.md: Added a main-only note for theoutcomelabel onagentgateway_mcp_requests_total, and added a main-only PromQL query for MCP tool call outcomes by tool.How to verify this change
Send MCP
tools/calltraffic through an existing agentgateway MCP route, including at least one tool response with"isError": true.Query the proxy metrics endpoint.
The output includes
agentgateway_mcp_requests_totalseries with theoutcomelabel. A tool error hasoutcome="tool_error", and a successful call hasoutcome="success".What was not verified
content/docs/standalone/main/documentation/observability/metrics/reference.mdalso listsagentgateway_mcp_requests_total, but the work-list did not authorize editing that page.How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4182 — feat: report MCP request outcomes in metrics
agentgateway/websiteRelease notes
This pull request also adds its release-note entries:
content/docs/kubernetes/main/release-notes/release-notes.md: MCP request outcome metric label (feature, in a new 1.8 section)content/docs/standalone/main/release-notes/release-notes.md: MCP request outcome metric label (feature, in a new 1.8 section)Check these release-note links and names. Each note is on its page, but a link may not reach the drafted content there, or a name may belong to the other mode:
content/docs/kubernetes/main/release-notes/release-notes.md: feat: report MCP request outcomes in metrics agentgateway#4182's note namestool_error, whichcontent/docs/standalone/mainmentions andcontent/docs/kubernetes/maindoes not. Check that this tree's readers can set it, or word the note for this mode.content/docs/standalone/main/release-notes/release-notes.md: feat: report MCP request outcomes in metrics agentgateway#4182's note namesprotocol_error, whichcontent/docs/kubernetes/mainmentions andcontent/docs/standalone/maindoes not. Check that this tree's readers can set it, or word the note for this mode.content/docs/standalone/main/release-notes/release-notes.md: feat: report MCP request outcomes in metrics agentgateway#4182's note namesgateway_error, whichcontent/docs/kubernetes/mainmentions andcontent/docs/standalone/maindoes not. Check that this tree's readers can set it, or word the note for this mode.Draft branch:
pr-tracker-draft-agentgateway-4182