Repository navigation
[Automated] Draft docs (agentgateway): http: normalize host header casing - #1457
Open
github-actions[bot] wants to merge 5 commits into
Open
github-actions[bot] wants to merge 5 commits into
github-actions[bot] wants to merge 5 commits into
Conversation
…sing Drafts-Commit: f2d874d Signed-off-by: GitHub Action <action@github.com>
Deploying agentproxy with
|
| Latest commit: |
6edf7c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a441ae05.agentproxy.pages.dev |
| Branch Preview URL: | https://pr-tracker-draft-agentgatewa-cfkp.agentproxy.pages.dev |
The release-notes entry for this change now lives in the combined release-notes PR, #1482, so the draft PRs no longer conflict on the release-notes pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Collaborator
|
Moved this PR's release-notes entry to the combined release-notes PR, #1482, so the draft PRs stop conflicting on the release-notes pages. Review or change the entry there. |
…match/host.md Signed-off-by: Kristin Brown <kristin.brown@solo.io>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Kristin Brown <kristin.brown@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered output was not compared with the base build: the site does not build at the base commit ed3fb85, so rendering outside the declared versions is unchecked.
agentgateway/agentgateway#4233 — http: normalize host header casing
Docs versions:
standalone/main,kubernetes/mainWhat changes for users: Requests whose
Hostheader casing differs from the configured hostname can now match the intended route or listener. Agentgateway normalizes the hostname for lookup, and forwards the originalHostheader casing unchanged.What the docs now say: The standalone Routes and Request matching pages now state that route and TCP hostname matching are case-insensitive. The Kubernetes Host matching page now says that a mixed-case
Hostheader can match a lowercase HTTPRoute hostname and that the upstream request keeps the original header casing.Not verified: No cluster or runtime was configured; the configuration is unrun, and internal links are unchecked.
How
agentgateway-4233was drafted, and what was not verifiedPlan, and what changed it
content/docs/standalone/main/documentation/configuration/routes.mdowns the standaloneroutes[].hostnamesfield, while the shared Kubernetes route-delegation overview does not own Host-header behavior.Why a documentation change is necessary
The pull request changes route and listener hostname lookup to compare hostnames case-insensitively, and its helper comment states that the original request
Hostheader is forwarded unchanged. The target pages already describe hostname-based route matching, but did not say how hostname casing behaves. Without this update, a reader might assume thatHost: EXAMPLE.comandhostnames: ["example.com"]do not match.What changed on disk
content/docs/kubernetes/main/documentation/traffic-management/match/host.md: Added the Kubernetes HTTPRoute Host-header matching behavior.content/docs/standalone/main/documentation/configuration/routes.md: Added the standaloneroutes[].hostnamescasing behavior beside the field description.content/docs/standalone/main/documentation/configuration/traffic-management/matching.md: Added the standalone TCP hostname matching casing behavior.How to verify this change
hostnames: ["example.com"]and send a request withcurl -i 127.0.0.1:3000/ -H "Host: EXAMPLE.com".curl -vi http://$INGRESS_GW_ADDRESS:80/status/200 -H "host: HOST1.Example".example.comorhost1.examplehostname, and a backend that records request headers should see the originalHostheader casing.Proposed release note
Wrote
proposed-release-note.mdbecause the change alters observable traffic routing behavior in both documented trees.What was not verified
Hostheader casing was not captured from a runtime backend.How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4233 — http: normalize host header casing
agentgateway/websiteRelease notes
This pull request also adds its release-note entries:
content/docs/kubernetes/main/release-notes/release-notes.md: http: normalize host header casing (fix, under Traffic management, in a new 1.8 section)content/docs/standalone/main/release-notes/release-notes.md: http: normalize host header casing (fix, under Traffic management, in a new 1.8 section)Draft branch:
pr-tracker-draft-agentgateway-4233