Repository navigation
feat: link extension traits for detached links (#389, stage 3) - #395
Merged
lxsaah merged 1 commit intoNov 2, 2026
Merged
Conversation
MqttLinkExt, MqttOutboundLinkExt, Ros2LinkExt and LinkCodecBuilderExt are implemented for OutboundLinkBuilder<T, R> / InboundLinkBuilder<T, R> instead of the attached aliases, so with_qos, with_retain, with_depth, with_reliability and with_link_codec also work on OutboundLink / InboundLink. Bodies are unchanged. Tests per crate check that a detached link records the same config as link_to / link_from. The usage guide gains a "Links as values" section. Stage 3 of design 059. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage 3 of 3 for #389 (design 059), into the #392 feature branch.
MqttLinkExt,MqttOutboundLinkExt(aimdb-mqtt-connector),Ros2LinkExt(aimdb-zenoh-connector) andLinkCodecBuilderExt(aimdb-data-contracts) are implemented forOutboundLinkBuilder<T, R>/InboundLinkBuilder<T, R>rather than the attached aliases. As a result,with_qos,with_retain,with_depth,with_reliabilityandwith_link_codecalso work onOutboundLink/InboundLink. Only the impl headers changed; the bodies are the same.link_extmodule docs name the generic builders and add a compiling example of the detached form, usingreg.input(..).output(..).docs/aimdb-usage-guide.mdgets a short "Links as values" section.Tests
detached_links_take_the_same_knobs: detached links with QoS, retain and the Postcard codec record the same config aslink_to/link_from, and both take the bounded payload path.tests/link_ext.rs: depth and reliability are recorded the same way on both forms.codec_verb_applies_to_detached_links: the codec and its recorded wire format on.output()/.input()links.Checked locally:
aimdb-data-contractstest command from the design doclink_ext_testsand doctestsclippy and the demo check are left to CI.
The changelog entries for all three stages follow in one commit on the feature branch before it merges to
main.Related Issue
🤖 Generated with Claude Code