Repository navigation
Conversation
The callback path resolved by CallbackTrigger must now be a coroutine function or an awaitable callable (such as an async notifier class), matching what AsyncCallback accepts. Anything else fails the callback before it is called, the same way trigger classpaths are validated. Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
Generated-by: Claude Opus 5 following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69792, which made the Triggerer check that a deferring task's trigger classpath resolves to a
BaseTriggersubclass before using it.CallbackTriggerresolves itscallback_pathwithimport_stringand calls the result without checking what it is. This PR checks the callback path the same way trigger classpaths are checked. Before the callback runs, the resolved object must be one of:async def),BaseNotifiersubclass (has__await__),__call__isasync def.The first two are what
AsyncCallback.verify_callablealready requires when a deadline callback is defined. Triggerer callbacks are always awaited, so every documented use is still accepted. Modules, non-callable attributes, plain classes and sync functions now fail the callback with a clearInvalidCallbackPathErrorand are not called. Before this change, a sync function was called and only then failed with a "not awaitable" error. Like any other callback failure, the error is reported as aFAILEDcallback event and the Triggerer keeps running.Tests added:
_validate_callback, one case each for accepted and rejected targets,CallbackTrigger.runtest that resolves a real coroutine-function path,CallbackTrigger.runtest that checks invalid paths (module, non-callable attribute, sync callable, plain class) fail without the target being called.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5 following the guidelines