Repository navigation
feat: support casting strings to durations #11572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miguelcorderopamphile
wants to merge
3
commits into
apache:main
Choose a base branch
from
miguelcorderopamphile:feat/string-to-duration-cast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
0463239
feat(arrow-cast): support casting strings to durations
miguelcorderopamphile ffa5e92
feat(arrow-cast): parse units when casting strings to durations
miguelcorderopamphile d047bf0
feat(arrow-cast): parse days when casting strings to durations
miguelcorderopamphile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we support only casting from numeric values? no units such as
1 hour 10 minutes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently numeric only: the cast reuses the existing
Duration*Typeparser impls (the same integer parsing the JSON reader uses).I can extend it to unit strings like
1 hour 10 minutesby going through the existing string→interval parser and theInterval(MonthDayNano) → Durationcast, which keeps the current semantics (months/days are not convertible —cast_month_day_nano_to_durationnulls/errors them).I could add it in this PR or keep this one numeric-only — your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be more useful if we could parse units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in ffa5e92 — non-integer strings now fall back to the interval parser, so "1 hour 10 minutes" casts to any Duration unit. Integer strings behave as before.
Months/days stay non-convertible to match the interval → duration cast (null when safe, error otherwise). I can change that if you'd rather treat "1 day" as 24h.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a good rule of thumb is to be able to roundtrip through the display representation:
arrow-rs/arrow-cast/src/display.rs
Lines 1591 to 1613 in 6db2d4f
can see how we display days here, so it would make sense to support parsing days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d047bf0 — days now convert at 24h/day (weeks fold into days in the parser), so pretty display strings roundtrip:
"45 days 14 hours 2 mins 34 secs"→ 3938554s for Duration(s). Months stay non-convertible since the duration display never emits them.