Repository navigation
Fix: Adding unhandled byteswaps for fixing endianness issues - #986
Merged
Merged
Conversation
|
It seems this patch die not made it into your last release. It would help a lot if you could tag a release incorporating this patch since the Debian package again failed on s390x architecture and will not migrate to testing due to this. |
Owner
|
Sure will do, this was posted after I posted the last release. Should be 1-2 weeks for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue reported in https://lists.debian.org/debian-s390/2026/09/msg00022.html
In
read_seqinfo, data was being read from the file directly and stored into a SeqInfo object. This caused the membersposandseq_lento have data in the wrong byte order. The overloaded>>operator handles this perfectly.In the function
is_diamond_db, data is read from a file directly as raw bytes into auint64_tvariablemagic_number. The original data in the file was little-endian and required a byteswap.