Skip to content

[TASK] Carry the uploads into a Branchery worktree - #1667

Merged
benjaminkott merged 1 commit into
masterfrom
task/branchery-uploads
Sep 14, 2026
Merged

benjaminkott merged 1 commit into
masterfrom
task/branchery-uploads

Conversation

@benjaminkott

Copy link
Copy Markdown
Owner

Description

A worktree built from the project's data rendered every image as a
404: the typo3-app profile carries config/sites and the settings
file along with the database, and the upload tree of this project lies
below .build/public, where nothing named it. data.needs now lists
.build/public/fileadmin, so a worktree gets the files its copied
sys_file rows point at.

Type of change

  • Bugfix
  • Task
  • Feature
  • Documentation

Related issues

Follows #1665. Backported to BP_16_0 in a separate pull request.

How to validate

  1. ddev branchery database:sync <worktree> — the log copies
    .build/public/fileadmin along with the database.
  2. An image of the worktree's frontend answers with 200 instead of 404.

AI assistance

  • Agent and version: Claude Code, VS Code extension
  • Model and effort/reasoning level: Claude Opus 5 (1M context), default
    effort
  • Share written by the agent: the change and this description
  • Reviewed and understood before pushing: not yet — opened on request,
    review pending

Checklist

  • Targets master
  • Commits are signed off (git commit -s)
  • Commit subjects follow [BUGFIX|TASK|FEATURE] Subject
  • composer cgl leaves the code unchanged — no PHP touched
  • composer phpstan passes — no PHP touched
  • composer test passes — no code touched
  • A bugfix comes with a test that fails without it — not
    applicable
  • Holds on every TYPO3 and PHP version declared in composer.json
    — development environment only
  • Assets rebuilt — not applicable
  • Documentation updated — not user facing

The typo3-app profile brings the site configuration and the settings
along with the data, but the upload tree of this project lies below
.build/public and has to be named to travel with it. Without it every
image of a worktree answers with a 404.

Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
@benjaminkott
benjaminkott merged commit df30aa3 into master Sep 14, 2026
10 checks passed
@benjaminkott
benjaminkott deleted the task/branchery-uploads branch September 14, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant