Repository navigation
[TASK] Carry the uploads into a Branchery worktree - #1667
Merged
Merged
Conversation
The typo3-app profile brings the site configuration and the settings along with the data, but the upload tree of this project lies below .build/public and has to be named to travel with it. Without it every image of a worktree answers with a 404. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
7 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A worktree built from the project's data rendered every image as a
404: the
typo3-appprofile carriesconfig/sitesand the settingsfile along with the database, and the upload tree of this project lies
below
.build/public, where nothing named it.data.needsnow lists.build/public/fileadmin, so a worktree gets the files its copiedsys_filerows point at.Type of change
Related issues
Follows #1665. Backported to
BP_16_0in a separate pull request.How to validate
ddev branchery database:sync <worktree>— the log copies.build/public/fileadminalong with the database.AI assistance
effort
review pending
Checklist
mastergit commit -s)[BUGFIX|TASK|FEATURE] Subjectcomposer cglleaves the code unchanged — no PHP touchedcomposer phpstanpasses — no PHP touchedcomposer testpasses — no code touchedapplicable
composer.json— development environment only