Repository navigation
[TASK] Drop v13 and allow v15@dev - #1669
Merged
Merged
Conversation
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
TYPO3 v15 stops reporting processed images to the AssetCollector, so the width and height the media rendering asks for came back empty. The files processed during the request are collected through AfterFileProcessingEvent instead, which every declared major fires. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
The frontend resolves the content areas of a page from its layout, and TYPO3 v15 refuses a column that has a colPos but no identifier where v14 derived one and logged a deprecation. The identifier is the name the column already carries in its label. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
scssphp deprecates raw PHP values for custom variables, a custom function without an argument declaration and a PHP return value from it, and drops all three in scssphp 2.0. The variables are parsed as Sass source the way the compiler read them itself, and url() returns the keyword it used to return as a string. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
The page renderer hands the stylesheets to the hook as PKG: resource identifiers, and getFileAbsFileName() deprecates resolving a file system path from one. The compiler needs that path to follow the imports of a stylesheet, so the package manager answers for a package resource. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
The palette and field labels the TCA borrowed from locallang_ttc.xlf and locallang_general.xlf are unused in the core since TYPO3 v14 and gone in v15, where every form of the package lost its palette headings. The same strings live in the core.form.palettes and frontend.db.tt_content domains on both declared majors. Database.xlf had already been gone since v14, and the type of a carousel item is labelled by the package. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Master becomes 17.0 and follows TYPO3 main: the package declares
^14.3 || 15.*.*@devand drops 13.4, the way the previous majorcrossing dropped 12.4. Everything the branch removes or changes comes
from what TYPO3 15 removed (Breaking-109783 and its siblings) and from
the deprecation log of the installation on both majors, which is empty
afterwards.
One commit per concern:
ext_emconf.php,CI matrix (15 runs on PHP 8.5 only), README, docs.
b13/containerleaves
require-dev: it has no release for 15, so acomposer updateagainst main could not resolve. The ^14.3 CI cells add itand PHPStan checks the container registration there.
composer typo3:devresolves the dependencies against thedevelopment major without touching
composer.json; the CI uses thesame
--with.< 14branches inext_localconf.php, the test skips, the routing note, the 13PHPStan baseline.
ones are gone in 15.
addPiFlexFormValue()isgone in 15.
cspinstead ofuseNonceonf:asset.css.reporting media to the AssetCollector,
<img width="" height="">was the result. A listener on
AfterFileProcessingEventcollectsthem on every declared major; the ViewHelper keeps its API.
dsinstead ofds.default— the TCA migration 14 logs.column without one, 14 derived a hash and logged; every page of
the site answered 500. 108 columns, identifier = label suffix.
url()without anargument declaration and with a PHP return value are deprecated in
scssphp 1.x and gone in 2.0.
renderer hands
PKG:identifiers to the compile hook, andgetFileAbsFileName()deprecates resolving those.borrowed from
locallang_ttc.xlfare gone in 15; every paletteheading in the forms was empty.
core.form.palettesandfrontend.db.tt_contentcarry the same strings on both majors.Type of change
Related issues
Needs
bk2k/extension-helper2.3 (released) for Symfony Console 8.b13/containerhas no release for TYPO3 15; the CI leaves it out ofthat cell until it has.
How to validate
Both majors were run as Branchery worktrees with a copy of the
development database — TYPO3 dev-main ccdcf13 on PHP 8.5.9, and
14.3.7 with b13/container 3.2.3:
composer test:php:lint,composer cgl:ci,composer phpstan,composer test:php:unit(96),composer test:php:functional(74)— green in both.
of 9 element types with their FlexForm fields and palette headings.
var/log/typo3_deprecations_*.logis empty after 2 and 3, on 14.3and on 15.
composer typo3:devon a checkout resolves to dev-main.Left as is: 10 PHP 8.5 deprecations of scssphp's own signatures and 18
PHPUnit 13 notices about mocks in the unit suite (pre-existing), and
the Extension Scanner was not run — the identifier sweep over
Breaking-109783 stands in.
AI assistance
effort
the v15 worktree were checked by hand; code review pending
Checklist
mastergit commit -s)[BUGFIX|TASK|FEATURE] Subjectcomposer cglleaves the code unchangedcomposer phpstanpassescomposer testpassesbugfixes (GalleryTest, BackendLayoutsTest)
composer.json— 14.3 and 15 locally on PHP 8.5, the rest is the CI matrix
guide, routing note