Skip to content

eth: try make work fine - #3884

Draft
will-2012 wants to merge 14 commits into
bnb-chain:codex/upstream-geth-v1.17.9-ci-fixfrom
will-2012:protocol-test-fixes
Draft

will-2012 wants to merge 14 commits into
bnb-chain:codex/upstream-geth-v1.17.9-ci-fixfrom
will-2012:protocol-test-fixes

Conversation

@will-2012

@will-2012 will-2012 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Enable eth/71 alongside eth/68, retaining BSC's TD handshake and block propagation. Restore BSC's block-number slot mapping for Amsterdam.

  • Preserve the eth/70 message handlers and add BAL exchange.
  • Fix test capability negotiation and calculate SNAP offsets from the negotiated ETH version.
  • Cover eth/68 and eth/71 handshakes, propagation, receipts and blob sync; fail when either required version is disabled.
  • Fix false positives in malformed handshake and removed SNAP message tests.
  • Derive and validate BSC slots from block numbers, keeping chain generation, RPC simulation and overrides consistent. Preserve Ethereum's CL-provided slots.

@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates the Go devp2p ETH/SNAP test harness to negotiate the highest mutually advertised protocol version and calculate message offsets from the negotiated ETH version. It adds ETH/68 BSC status/upgrade handling, expands ETH and SNAP test matrices across versions 68, 70, and 71, and tightens malformed-handshake and removed SNAP-message assertions.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@will-2012
will-2012 marked this pull request as draft November 16, 2026 07:54
@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates the Go-based Ethereum/BSC devp2p implementation and test harness to negotiate the highest exact ETH/SNAP capability shared by both peers and to compute SNAP message offsets from the negotiated ETH version. It adds dedicated BSC eth/68 status/upgrade handling, enables eth/71 as the primary protocol with block propagation and eth/70-style handshakes, and expands ETH/SNAP synchronization, handshake, propagation, and malformed-message tests across eth/68 and eth/71.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@will-2012 will-2012 changed the title cmd/devp2p: fix eth protocol tests eth, cmd/devp2p: enable eth/71 with TD Nov 16, 2026
@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR enables BSC’s eth/71 protocol alongside eth/68, retaining total-difficulty handshakes, block propagation, receipt pagination, and block access list exchange while making capability negotiation and protocol offsets version-aware. It substantially expands eth/68 and eth/71 handshake, synchronization, propagation, SNAP, and malformed-message coverage, and also enforces BSC Amsterdam slot numbers as block numbers across consensus validation, mining, simulation, chain generation, and RPC overrides.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@will-2012 will-2012 changed the title eth, cmd/devp2p: enable eth/71 with TD eth, cmd/devp2p: try enable all works Nov 16, 2026
@will-2012 will-2012 changed the title eth, cmd/devp2p: try enable all works eth, miner: enable eth/71 and fix BSC slot numbers Nov 16, 2026
@will-2012 will-2012 changed the title eth, miner: enable eth/71 and fix BSC slot numbers eth, miner: try make works Nov 16, 2026
@will-2012 will-2012 changed the title eth, miner: try make works eth, miner: try make work fine Nov 16, 2026
zlacfzy and others added 6 commits November 16, 2026 19:30
Collect BALs returned by Parlia system transaction finalization during
serial BSC import. Record block-begin upgrades at index 0 and trailing
protocol mutations at n+1, preserving the next included transaction
scope for preceding protocol mutations.

Keep direct protocol reads and omitted transaction attempts out of the
BAL. Gate collection on BSC Amsterdam without enabling mining BAL
construction or parallel execution.
Move block-begin upgrades and their BAL recording into PreExecution.
Apply post-normal-transaction upgrades in PostExecution before Parlia
executes system transactions, leaving their journal changes pending
for the next included transaction or the final n+1 scope.

Update mining, BidBlock and replay callers for the shared phases, and
cover Jenner upgrade timing and BAL replay before and after Amsterdam.
Keep BAL replay in the Parlia integration test and remove duplicate
replay and direct-finalization comparisons. Exercise the helper through
a traced StateDB, with the integration test covering the plain path.
Keep Feynman-era contract upgrades at the start of Parlia finalization.
Run BSC post-execution after system transactions and collect remaining
protocol changes at n+1. Share the same ordering for signed mining and
unsigned BidBlock assembly before computing the final state root.

Restore the upstream PostExecution signature and preserve Ethereum
ordering. Update simulation and extend the Parlia integration test
to check post-execution ordering and packed/imported state agreement.
@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates the Go-based BSC/Ethereum client to advertise and support eth/71 alongside eth/68, including capability negotiation, version-specific message offsets, handshakes, block propagation, BAL exchange, receipts, blob synchronization, and expanded conformance tests. It also integrates Amsterdam block access lists with Parlia system transactions and system-contract upgrades, enforces BSC slot numbers derived from block numbers, and aligns mining, simulation, tracing, overrides, and chain generation with those rules.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates a BSC-flavored Go Ethereum client to negotiate and support eth/71 alongside eth/68, including eth/71 handshakes, block propagation, BAL exchange, version-specific protocol offsets, and broader sync/conformance coverage. It also integrates Amsterdam block access lists with Parlia system transactions, introduces BSC block-number-based slot mapping, and updates post-Amsterdam payment-lane gas accounting across execution, mining, simulation, tracing, and validation paths.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates a Go-based BSC/go-ethereum client to enable eth/71 alongside eth/68, including version-aware protocol negotiation, handshakes, message offsets, block propagation, BAL exchange, synchronization, and expanded conformance tests. It also integrates Amsterdam behavior across Parlia block assembly and validation, BSC block-number-derived slots, block access lists, two-dimensional gas and payment-lane accounting, CAS20 gas metering, tracing, simulation, and MEV bid handling.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates the BSC/go-ethereum client to advertise and support eth/71 alongside eth/68, including version-aware protocol offsets, eth/71 handshakes, block propagation, BAL exchange, receipts, blob synchronization, and expanded conformance tests. It also integrates Amsterdam behavior across Parlia block assembly and validation, block access lists, two-dimensional gas/payment-lane accounting, CAS20 gas metering, BSC block-number-based slots, RPC simulation/tracing, and MEV bid handling.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@will-2012 will-2012 changed the title eth, miner: try make work fine eth: try make work fine Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants