Repository navigation
Conversation
Pull Request ReviewThis PR updates the Go devp2p ETH/SNAP test harness to negotiate the highest mutually advertised protocol version and calculate message offsets from the negotiated ETH version. It adds ETH/68 BSC status/upgrade handling, expands ETH and SNAP test matrices across versions 68, 70, and 71, and tightens malformed-handshake and removed SNAP-message assertions. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR updates the Go-based Ethereum/BSC devp2p implementation and test harness to negotiate the highest exact ETH/SNAP capability shared by both peers and to compute SNAP message offsets from the negotiated ETH version. It adds dedicated BSC eth/68 status/upgrade handling, enables eth/71 as the primary protocol with block propagation and eth/70-style handshakes, and expands ETH/SNAP synchronization, handshake, propagation, and malformed-message tests across eth/68 and eth/71. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR enables BSC’s eth/71 protocol alongside eth/68, retaining total-difficulty handshakes, block propagation, receipt pagination, and block access list exchange while making capability negotiation and protocol offsets version-aware. It substantially expands eth/68 and eth/71 handshake, synchronization, propagation, SNAP, and malformed-message coverage, and also enforces BSC Amsterdam slot numbers as block numbers across consensus validation, mining, simulation, chain generation, and RPC overrides. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Collect BALs returned by Parlia system transaction finalization during serial BSC import. Record block-begin upgrades at index 0 and trailing protocol mutations at n+1, preserving the next included transaction scope for preceding protocol mutations. Keep direct protocol reads and omitted transaction attempts out of the BAL. Gate collection on BSC Amsterdam without enabling mining BAL construction or parallel execution.
Move block-begin upgrades and their BAL recording into PreExecution. Apply post-normal-transaction upgrades in PostExecution before Parlia executes system transactions, leaving their journal changes pending for the next included transaction or the final n+1 scope. Update mining, BidBlock and replay callers for the shared phases, and cover Jenner upgrade timing and BAL replay before and after Amsterdam.
Keep BAL replay in the Parlia integration test and remove duplicate replay and direct-finalization comparisons. Exercise the helper through a traced StateDB, with the integration test covering the plain path.
Keep Feynman-era contract upgrades at the start of Parlia finalization. Run BSC post-execution after system transactions and collect remaining protocol changes at n+1. Share the same ordering for signed mining and unsigned BidBlock assembly before computing the final state root. Restore the upstream PostExecution signature and preserve Ethereum ordering. Update simulation and extend the Parlia integration test to check post-execution ordering and packed/imported state agreement.
Pull Request ReviewThis PR updates the Go-based BSC/Ethereum client to advertise and support eth/71 alongside eth/68, including capability negotiation, version-specific message offsets, handshakes, block propagation, BAL exchange, receipts, blob synchronization, and expanded conformance tests. It also integrates Amsterdam block access lists with Parlia system transactions and system-contract upgrades, enforces BSC slot numbers derived from block numbers, and aligns mining, simulation, tracing, overrides, and chain generation with those rules. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR updates a BSC-flavored Go Ethereum client to negotiate and support eth/71 alongside eth/68, including eth/71 handshakes, block propagation, BAL exchange, version-specific protocol offsets, and broader sync/conformance coverage. It also integrates Amsterdam block access lists with Parlia system transactions, introduces BSC block-number-based slot mapping, and updates post-Amsterdam payment-lane gas accounting across execution, mining, simulation, tracing, and validation paths. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR updates a Go-based BSC/go-ethereum client to enable eth/71 alongside eth/68, including version-aware protocol negotiation, handshakes, message offsets, block propagation, BAL exchange, synchronization, and expanded conformance tests. It also integrates Amsterdam behavior across Parlia block assembly and validation, BSC block-number-derived slots, block access lists, two-dimensional gas and payment-lane accounting, CAS20 gas metering, tracing, simulation, and MEV bid handling. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR updates the BSC/go-ethereum client to advertise and support eth/71 alongside eth/68, including version-aware protocol offsets, eth/71 handshakes, block propagation, BAL exchange, receipts, blob synchronization, and expanded conformance tests. It also integrates Amsterdam behavior across Parlia block assembly and validation, block access lists, two-dimensional gas/payment-lane accounting, CAS20 gas metering, BSC block-number-based slots, RPC simulation/tracing, and MEV bid handling. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Pull Request ReviewThis PR updates the BSC-flavored Go Ethereum client to negotiate and support eth/71 alongside eth/68, including block propagation, BAL exchange, version-specific handshakes and SNAP protocol offsets. It also integrates Amsterdam block access lists and block-number-based slot mapping into Parlia execution, mining, simulation, tracing, payment-lane gas accounting, MEV bid handling, and snap/2 pivot recovery, with extensive tests. Sensitive ContentNo sensitive content detected. Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
Enable eth/71 alongside eth/68, retaining BSC's TD handshake and block propagation. Restore BSC's block-number slot mapping for Amsterdam.