Skip to content

fix: restore node@20 support - #225

Merged
nikku merged 3 commits into
mainfrom
nikku-bpmnlint-node-20-support
Nov 12, 2026
Merged

nikku merged 3 commits into
mainfrom
nikku-bpmnlint-node-20-support

Conversation

@nikku

@nikku nikku commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

Patch for 12.x: restore node@20 support, reverting the Node 24 requirement introduced in 12.0.0. Continue with 12.x and retain the existing exports declaration.

Require @bpmn-io/lint-core@^0.1.1, which supports Node 20 following bpmn-io/lint-core#2. Add Node 20 CI coverage, keep Node 24 as the standard runtime, and retain Node 26 and platform coverage. The changelog records the compatibility fix and dependency update.

The full suite passes on Node 20.20 and Node 24, and an engine-strict production install of the packed package succeeds on Node 20.20. The existing lockfile's bpmn-moddle@10.1.0 requires Node >=20.12; several development dependencies require newer Node versions, so this does not promise engine-strict development installs on Node 20 or support for every Node 20 minor.

To try it out, use Node 20 or Node 24 and run npm ci && npm run all. No linked issue or UI changes apply.

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

@bpmn-io-tasks bpmn-io-tasks Bot added the in progress Currently worked on label Nov 12, 2026
@nikku
nikku marked this pull request as ready for review November 12, 2026 09:11
@nikku
nikku requested review from a team and a balanced review from Copilot November 12, 2026 09:11
@bpmn-io-tasks bpmn-io-tasks Bot added needs review Review pending and removed in progress Currently worked on labels Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The declared Node support includes 20.0–20.11, but bpmn-moddle@10.1.0 requires Node >=20.12, causing engine-strict installs to fail within the advertised range.

1 open issue
What changed in this PR

This PR restores declared Node 20 support and CI coverage for bpmnlint while keeping Node 24 as the standard runtime.

Changes:

  • Lowers the declared Node engine minimum from 24 to 20.
  • Updates @bpmn-io/lint-core to the Node 20-compatible ^0.1.1 release.
  • Adds Node 20 checks alongside existing Node 24 and Node 26 coverage.
File Description
package.json Updates the Node engine range and lint-core dependency requirement.
package-lock.json Synchronizes engine metadata and locks lint-core to version 0.1.1.
.github/​workflows/​CI.yml Adds Node 20 to the compatibility test matrix.

Review effort: Balanced

Comment thread package.json Resolved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@nikku
nikku force-pushed the nikku-bpmnlint-node-20-support branch from 131d259 to cfc8313 Compare November 12, 2026 09:15
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@nikku nikku changed the title fix: restore node 20 support fix: restore node@20 support Nov 12, 2026
@nikku
nikku merged commit 3877f89 into main Nov 12, 2026
14 checks passed
@bpmn-io-tasks bpmn-io-tasks Bot removed the needs review Review pending label Nov 12, 2026
@nikku
nikku deleted the nikku-bpmnlint-node-20-support branch November 12, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants