Repository navigation
GH282: Evaluate runtime-async TargetFramework condition in Sdk.targets - #283
Merged
Merged
Conversation
devlead
commented
Nov 8, 2026
Member
- Move the net11.0 Features runtime-async=on opt-in from generated Sdk.props / build/Cake.Sdk.props to Sdk.targets / build/Cake.Sdk.targets so the condition sees the project's final TargetFramework.
- Fixes file-based net10.0 apps on the .NET 11 SDK getting runtime-async (SYSLIB5007/CA2252), and project-based net11.0 consumers never getting it.
- fixes Cake.Sdk runtime-async TargetFramework condition evaluated too early in Sdk.props #282
…n Sdk.targets - Move the net11.0 Features runtime-async=on opt-in from generated Sdk.props / build/Cake.Sdk.props to Sdk.targets / build/Cake.Sdk.targets so the condition sees the project's final TargetFramework. - Fixes file-based net10.0 apps on the .NET 11 SDK getting runtime-async (SYSLIB5007/CA2252), and project-based net11.0 consumers never getting it. - fixes cake-build#282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.