Repository navigation
refactor(mint): clarify shared ownership and signature query docs - #2904
Merged
Merged
Conversation
Use explicit Arc clones and move the original signatory into the pubsub context. Document that signature-query tuples contain blinded secrets, ordered by output index.
This was referenced Nov 16, 2026
thesimplekid
changed the base branch from
main
to
fix/restore-signature-validation
November 16, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up shared ownership and database documentation after #2226.
Use explicit
Arc::clonecalls when constructing the mint and move the original signatory handle into the pub/sub context, avoiding an unnecessary clone. Correct the signature-query documentation to describe the returned blinded secrets and their ordering by output index.Notes to the reviewers
Review and merge order: #2902 → #2903 → #2904.
Stacked on #2903. This final PR contains only ownership cleanup and documentation changes; it does not change restore behavior.
Suggested CHANGELOG Updates
None; internal refactoring and documentation corrections.
Checklist
just quick-checkbefore committing