Repository navigation
fix(cdk-common): make jsonwebtoken optional behind http feature - #2927
Open
thesimplekid wants to merge 1 commit into
Open
thesimplekid wants to merge 1 commit into
thesimplekid wants to merge 1 commit into
Conversation
jsonwebtoken is only used by auth::oidc, which is compiled only with the http feature, yet it was always a dependency. Builds without http pulled it in along with its p256/p384 crypto dependencies, and wasm32 checks warned about an unused dependency. Make it optional and enable it from the http feature. The getrandom 0.2 js workaround stays unconditional on wasm32: bitcoin's rand-std feature also pulls getrandom 0.2 through secp256k1 and rand 0.8, so it is needed even without http. Update its comment accordingly. Refs cashubtc#2923
thesimplekid
force-pushed
the
json_option
branch
from
November 18, 2026 20:52
ab66b2c to
c48bf89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonwebtoken is only used by auth::oidc, which is compiled only with the http feature, yet it was always a dependency. Builds without http pulled it in along with its p256/p384 crypto dependencies, and wasm32 checks warned about an unused dependency.
Make it optional and enable it from the http feature.
The getrandom 0.2 js workaround stays unconditional on wasm32: bitcoin's rand-std feature also pulls getrandom 0.2 through secp256k1 and rand 0.8, so it is needed even without http. Update its comment accordingly.
Refs #2923
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)