Repository navigation
ci: run rusqlite compatibility checks on self-hosted runners - #2928
Merged
Merged
Conversation
The rusqlite-compat matrix is a plain nix build with no dependency on the integration test binaries, yet it ran on the rith-cdk pool. With no needs, both matrix legs claimed Rith slots the moment a CI run started, ahead of the integration tests that can only run there. Move the job to the self-hosted pool, and gate it on pre-commit-checks like the other self-hosted jobs, so Rith capacity goes to the integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rusqlite-compat matrix is a plain nix build with no dependency on the integration test binaries, yet it ran on the rith-cdk pool. With no needs, both matrix legs claimed Rith slots the moment a CI run started, ahead of the integration tests that can only run there.
Move the job to the self-hosted pool, and gate it on pre-commit-checks like the other self-hosted jobs, so Rith capacity goes to the integration tests.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)