Repository navigation
update setup.py requirements to use Flask 2 - #18
Open
nickhilliard wants to merge 11 commits into
Open
nickhilliard wants to merge 11 commits into
nickhilliard wants to merge 11 commits into
Conversation
update requirements to use Flask 2
and 3.1.3 with deprecation warnings treated as errors, with no code changes required over Flask 1. Drop pytest-flask: the tests define their own client fixture and use none of its fixtures. Remove the Flask 1.x reference from the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
contain non-ASCII characters, so a Basic auth password or X-API-Key with such characters made the proxy return 500. Compare the keys as UTF-8 bytes instead. The existing auth tests only asserted status_code > 400, which a 500 also satisfies, so add a test that requires exactly 401. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
deprecation of earlier versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Default-deny zone creation. The allow-suffix-creation check was only applied when the key was present in a user's config, so any authenticated user without that key could create arbitrary zones (they became the owner via the account override). Absence of the key now means no creation rights, and an empty rule denies as well. - Reject empty configured keys. A user configured with "key =" (empty) could be authenticated with an empty password over both X-API-Key and Basic auth. Treat an empty stored key as never matching. - Return 400 instead of 500 when a zone-creation request has no "name" (or a non-string name), which previously raised an unhandled AttributeError. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
without the setting cannot create zones. Use "allow-suffix-creation = ." to allow any zone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.