Repository navigation
Allow credential-scoped JFrog S3 npm redirects - #319
Open
dzmitry-zhdanovich wants to merge 1 commit into
Open
dzmitry-zhdanovich wants to merge 1 commit into
dzmitry-zhdanovich wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Allow npm artifact downloads from the configured Wolters Kluwer Artifactory registry. Its artifact request redirects to
jfrog-platform.s3.eu-west-1.amazonaws.com, which was blocked by egress filtering. The redirect host is now derived only for jobs configured with the exact Artifactory registry hostname.Resolves the reported egress block during npm package installation. No issue number was provided.
Anything you want to highlight for special attention from reviewers?
The S3 host is deliberately not added to a global allowlist.
registry_redirect_derivationspermits this exact destination only for jobs whose registry credential namesartifactory.wolterskluwer.io. The reported 302 establishes the redirect relationship; the S3 endpoint's unsigned 403 response does not independently establish bucket ownership. Exact host matching avoids opening sibling hosts or other regions, and no signed query parameters are included.How will you know you've accomplished your goal?
Regression tests verify that the configured registry's artifact destination is allowed, while the destination remains blocked without that registry credential and for lookalike/other-region hosts.
Validation:
docker run --rm --entrypoint /bin/sh dependabot/proxy-builder-tests -c 'go build ./... && go test ./internal/handlers/ -run TestEgress -count=1'- passed.docker run --rm --entrypoint /bin/sh dependabot/proxy-builder-tests -c 'go test -race -shuffle=on -count=2 ./...'- passed.script/testwrapper could not run directly because the checked-out shell script has CRLF line endings; its Docker test command was run directly. No separate linter was run.Checklist