Repository navigation
Allowlist applesdk.vindral.com for Swift binaryTargets - #325
Merged
v-robaiken merged 1 commit intoOct 16, 2026
Merged
Conversation
The Vindral Apple SDK (RealSprint/vindral-apple-sdk-spm) declares its VindralStreaming binaryTarget at applesdk.vindral.com. SwiftPM fails with a 403 from the egress proxy, so the whole Swift update job errors out. Exact host only; vindral.com's wildcard cert also covers the vendor's CDN and stage/test hosts.
sothebys-valdi
force-pushed
the
allowlist-applesdk-vindral-com
branch
from
October 16, 2026 07:10
a6b7cf8 to
2f0b045
Compare
sothebys-valdi
marked this pull request as ready for review
October 16, 2026 07:26
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped change includes appropriate boundary coverage and has no identified blocking issues; tests were not run in this environment.
0 open findings
What changed in this PR
Allows Dependabot to download the Vindral Swift SDK without widening access to other Vindral hosts.
Changes:
- Adds the exact host
applesdk.vindral.comto the allowlist. - Adds regression coverage for SDK downloads and blocked child, sibling, and parent hosts.
| File | Description |
|---|---|
| internal/handlers/egress_allowlist_test.go | Tests allowed SDK downloads and blocked related hosts. |
| internal/handlers/egress_allowlist_defaults.yaml | Adds the documented exact-host entry. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-robaiken
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Dependabot checks started failing every time for my SwiftPM package that includes the Vindral SDK.
I want it to work again for the dependencies in that package.
The Vindral Apple SDK (RealSprint/vindral-apple-sdk-spm) declares its VindralStreaming binaryTarget at applesdk.vindral.com. SwiftPM fails with a 403 from the egress proxy, so the whole Swift update job errors out. Exact host only; vindral.com's wildcard cert also covers the vendor's CDN and stage/test hosts.
This fixes the issue of the Vindral SDK being blocked due to
https://applesdk.vindral.comnot being in the egress allowlist.Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
The Dependabot checks will start working again for our local SwiftPM package.
Checklist
Note
Disclaimer about unchecked checklist items:
I can't run tests requiring Docker Desktop on my Mac due to the Docker commercial license. I would appreciate it if this minor allowlist addition can still be reviewed.