Repository navigation
fix(auth): make emailed login/reset links scanner-safe - #67
Merged
Merged
Conversation
The /admin/login/link page auto-redirected to Supabase's /auth/v1/verify on load, so email security scanners (e.g. Microsoft Safe Links, which prefetch every link for @ufl.edu recipients) consumed the single-use token before the user clicked — links appeared to expire instantly. - Render a confirmation button instead; verification now only fires on an explicit click - Pass the link type through the email URL and route recovery links to the reset-password page instead of hardcoding type=magiclink - Stop logging the live action link
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Invite/reset links "expire instantly". Root cause:
/admin/login/linkauto-redirected to Supabase's/auth/v1/verifyon page load. Our users are on@ufl.edu(Microsoft 365), and Outlook/Defender Safe Links prefetches every emailed URL — that prefetch followed the redirect and consumed the single-use token before the human ever clicked.What
/admin/login/linknow renders a confirmation button; verification fires only on an explicit click (scanners don't click).type; recovery links redirect to/admin/login/reset-password(which already handles the token hash) instead of the previous hardcodedtype=magiclink→/admin/login/, which broke reset flows.console.logof the live action link (credential leak into Vercel logs — audit finding).Verification
npm run buildpasses.