Repository navigation
Add header/footer block support - #12
Merged
Merged
Conversation
… value objects for consistent formatting in extension methods
eNeRGy164
force-pushed
the
header-footer
branch
from
January 18, 2026 19:43
1fc991c to
b701912
Compare
Pull Request Test Coverage Report for Build 21117685909Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR adds header and footer block support with alignment options, pragma directive support, mainframe titles for sequence diagrams, and introduces an Alignment value object to standardize horizontal alignment across PlantUML commands.
Changes:
- Added block-style header/footer commands (
HeaderStart,FooterStart,EndHeader,EndFooter) and alignment support to existing header/footer methods - Added
Pragmaextension methods for pragma directives with string and boolean values - Added
Mainframemethod for sequence diagram titles andAlignmentvalue object for standardizing horizontal alignment
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/PlantUml.Builder.Tests/StringBuilderExtensions/PragmaTests.cs | Adds comprehensive tests for pragma directives including validation |
| tests/PlantUml.Builder.Tests/StringBuilderExtensions/HeaderTests.cs | Adds tests for newline escaping, alignment options, and header block methods |
| tests/PlantUml.Builder.Tests/StringBuilderExtensions/FooterTests.cs | Adds tests for newline escaping, alignment options, and footer block methods |
| tests/PlantUml.Builder.Tests/SequenceDiagrams/StringBuilderExtensions/MainframeTests.cs | Adds tests for mainframe titles with validation |
| tests/PlantUml.Builder.Tests/AlignmentTests.cs | Tests Alignment value object construction and normalization |
| tests/PlantUml.Builder.Tests/Alignment.DefaultsTests.cs | Tests static Alignment properties (Left, Center, Right) |
| tests/PlantUml.Builder.Examples/SequenceDiagramExampleTests.cs | Adds mainframe example matching PlantUML documentation |
| src/PlantUml.Builder/StringBuilderExtensions/Pragma.cs | Implements pragma directive rendering with string and boolean overloads |
| src/PlantUml.Builder/StringBuilderExtensions/Header.cs | Adds alignment parameter, newline escaping, and block-style header methods |
| src/PlantUml.Builder/StringBuilderExtensions/Footer.cs | Adds alignment parameter, newline escaping, and block-style footer methods |
| src/PlantUml.Builder/SequenceDiagrams/StringBuilderExtensions/Mainframe.cs | Implements mainframe title rendering for sequence diagrams |
| src/PlantUml.Builder/Constant.cs | Adds constants for Exclamation, Center, Mainframe, and Pragma |
| src/PlantUml.Builder/Alignment.cs | New value object for normalizing horizontal alignment values |
| docs/commands.md | Updates command documentation to reflect new implementations |
| docs/arc42/10_quality_requirements.md | Adds documentation sample fidelity requirement |
| docs/arc42/09_architecture_decisions.md | Documents centralized token management and value object patterns |
| docs/arc42/08_crosscutting_concepts.md | Adds value object guidance and example test documentation |
| docs/arc42/04_solution_strategy.md | Adds two-tier testing strategy documentation |
| AGENTS.md | New file documenting repository structure and contribution guidelines |
Comments suppressed due to low confidence (1)
docs/arc42/08_crosscutting_concepts.md:50
- Grammar issue: "exact PlantUML output for method" should be "exact PlantUML output for the method" or "exact PlantUML output for each method".
Use the existing expectation helpers to assert the exact PlantUML output for method and cover representative input combinations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eNeRGy164
force-pushed
the
header-footer
branch
from
January 18, 2026 19:54
b701912 to
add38d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.